Commit e2de72a
committed
fix(golden): listen on merge_group event so gate posts status under merge queue
This repo uses GitHub's merge queue (per build.yml's existing
merge_group trigger). When a PR enters the queue, GitHub dispatches a
merge_group event against an ephemeral ref, not pull_request. A
required check that only declares on.pull_request never reports a
status on the merge_group event, so the merge queue treats it as
missing/pending and blocks the merge — the same skipped-but-required
failure mode the path-filter pitfall was about, just under a different
trigger.
Mirror build.yml's pattern: listen on both pull_request and
merge_group with the same branch filters. The check_semver_bump.py
script's self-gating (exit 0 when no expected.*.yaml changed) only
helps when the workflow runs at all; this fix makes it run.
Add a small "resolve base ref" step because the two event types
expose the target branch differently: pull_request sets
github.base_ref to the bare branch name; merge_group leaves
base_ref empty and exposes the full ref at
github.event.merge_group.base_ref (e.g. "refs/heads/develop"),
which we strip to match the pull_request shape before passing to
check_semver_bump.py.
Caught by review on PR #9057.1 parent f17c4c5 commit e2de72a
1 file changed
Lines changed: 38 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
12 | 21 | | |
13 | 22 | | |
14 | 23 | | |
15 | 24 | | |
16 | 25 | | |
17 | 26 | | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
18 | 33 | | |
19 | 34 | | |
20 | 35 | | |
| |||
30 | 45 | | |
31 | 46 | | |
32 | 47 | | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
33 | 63 | | |
34 | 64 | | |
35 | | - | |
| 65 | + | |
36 | 66 | | |
37 | 67 | | |
38 | 68 | | |
| |||
0 commit comments