chore(golden): clean ruff nits in new tests/golden/ files

Drop unused pytest/yaml imports across the new tests, and replace
the rename-detection magic number in check_semver_bump.py with a
named constant. No behavior change. Surfaces from ruff check
tests/golden when run directly (the project's `make lint` target
restricts to samcli/schema, so these escaped CI).

Author: bnusunny

tests/golden/check_semver_bump.py

@@ -16,6 +16,9 @@
 
 EXPECTED_GLOB = re.compile(r"^tests/golden/templates/.+/expected\.(build|package)\.yaml$")
 
+# git diff --name-status emits "R<score>\tOLD\tNEW" for renames (3 fields).
+_RENAME_DIFF_PARTS = 3
+
 
 @dataclass(frozen=True)
 class Change:
@@ -102,7 +105,7 @@ def _git_changed_files(base: str, head: str) -> List[Change]:
         parts = line.split("\t")
         status, path = parts[0], parts[-1]
         # Renames present as "R<score>\tOLD\tNEW" — split into D + A for our purposes.
-        if status.startswith("R") and len(parts) == 3:
+        if status.startswith("R") and len(parts) == _RENAME_DIFF_PARTS:
             old, new = parts[1], parts[2]
             changes.append(Change(old, "D"))
             changes.append(Change(new, "A"))

tests/golden/conftest.py

@@ -6,8 +6,6 @@
 
 from pathlib import Path
 
-import pytest
-
 TEMPLATES_ROOT = Path(__file__).parent / "templates"
 
 

tests/golden/test_check_semver_bump.py

@@ -4,8 +4,6 @@
 the lower-level entrypoint.
 """
 
-import pytest
-
 from tests.golden import check_semver_bump as csb
 
 

tests/golden/test_corpus.py

@@ -2,8 +2,6 @@
 
 from pathlib import Path
 
-import pytest
-
 from tests.golden.harness import run_build_pipeline, run_package_pipeline
 from tests.golden.normalize import normalize
 from tests.golden.update_goldens import _read_metadata, _resolve_le_default

tests/golden/test_harness_build.py

@@ -2,9 +2,6 @@
 
 from pathlib import Path
 
-import pytest
-import yaml
-
 from tests.golden.harness import run_build_pipeline
 
 CASES_ROOT = Path(__file__).parent / "templates"

tests/golden/test_harness_package.py

@@ -2,8 +2,6 @@
 
 from pathlib import Path
 
-import pytest
-
 from tests.golden.harness import run_build_pipeline, run_package_pipeline
 
 CASES_ROOT = Path(__file__).parent / "templates"

tests/golden/test_normalize.py

@@ -1,7 +1,5 @@
 """Unit tests for normalize() — deterministic YAML serialization."""
 
-import pytest
-
 from tests.golden.normalize import normalize