refactor(test): allow linux integ test to run in github action#8386
Merged
Conversation
vicheey
previously approved these changes
Nov 3, 2025
seshubaws
reviewed
Nov 4, 2025
seshubaws
reviewed
Nov 4, 2025
fix remote test event failure
Contributor
|
In PR description says "Integ Test can not be run in github action due to multiple reason." Could you expand on the reasons for posterity? Otherwise, LGTM |
seshubaws
approved these changes
Nov 4, 2025
vicheey
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Integ Test can not be run in Github Action (GA) before due to multiple reason.
Why is this change necessary?
Provide faster and more stable testing experience
How does it address the issue?
Test run: https://github.com/roger-zhangg/aws-sam-cli/actions/runs/18965218688
Newer test run: https://github.com/roger-zhangg/aws-sam-cli/actions/runs/19054600514
Takes only ~30 minute to finish all tests
What side effects does this change have?
payload_data = json.dumps({"skip_role_deletion": True}))Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.