Skip to content

Chore(test): update rbenv#8419

Merged
roger-zhangg merged 2 commits into
aws:developfrom
roger-zhangg:rbenv3
Nov 10, 2025
Merged

Chore(test): update rbenv#8419
roger-zhangg merged 2 commits into
aws:developfrom
roger-zhangg:rbenv3

Conversation

@roger-zhangg

Copy link
Copy Markdown
Member

Which issue(s) does this change fix?

rbenv in appveyor doesn't support 3.4.7 yet

Why is this change necessary?

How does it address the issue?

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@roger-zhangg
roger-zhangg requested a review from a team as a code owner November 8, 2025 00:21
valerena
valerena previously approved these changes Nov 8, 2025
@valerena

valerena commented Nov 8, 2025

Copy link
Copy Markdown
Contributor

I guess we're migrating out of AppVeyor soon, but something that probably works for GitHub actions too: (not for now, but maybe if you see something like this in the future)

We should create more small scripts (under tests/ maybe) that do these kind of "multi-steps" actions, like install_ruby.sh that hides the complexity for the installation and we can just call from the big scripts. That way we need just one line of code for all the tests that run Ruby tests instead of having to put all the steps in all the places.

@roger-zhangg
roger-zhangg added this pull request to the merge queue Nov 10, 2025
Merged via the queue into aws:develop with commit 952cf63 Nov 10, 2025
78 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants