Skip to content

chore: update docker api version #8428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seshubaws wants to merge 1 commit into from
Closed

chore: update docker api version #8428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion samcli/lib/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
DOCKER_MIN_API_VERSION = "1.35"
DOCKER_MIN_API_VERSION = "1.44"
3 changes: 2 additions & 1 deletion tests/unit/local/docker/test_container_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
ContainerArchiveImageLoadFailedException,
ContainerInvalidSocketPathException,
)
from samcli.lib.constants import DOCKER_MIN_API_VERSION


class BaseContainerClientTestCase(TestCase):
Expand All @@ -31,7 +32,7 @@ def setUp(self):
"""Set up common test fixtures"""
self.finch_socket = "unix:///tmp/finch.sock"
self.docker_socket = "unix:///var/run/docker.sock"
self.default_version = "1.35"
self.default_version = DOCKER_MIN_API_VERSION

def create_mock_container_client(self, client_class, methods_to_bind=None):
"""Create a mock container client with bound methods for testing."""
Expand Down
Loading