chore: update docker api version#8429
Conversation
|
Need to get an update in AppVeyor's Windows env to have 1.44 version of docker api too before merging this, it's currently 1.40. Cut a ticket to them |
|
https://github.com/aws/aws-sam-cli/actions/runs/19347164833 |
|
Finch has some compatibility issue, checking now |
|
Finch has to update their version https://github.com/runfinch/finch-daemon/blob/43a3326118f14ca06f8b2abf868fa3d7eefdb43a/version/version.go#L11 |
|
https://github.com/aws/aws-sam-cli/actions/runs/19355963514 most integ tests passing now |
| self.docker_socket = "unix:///var/run/docker.sock" | ||
| self.default_version = "1.35" | ||
| self.docker_version = DOCKER_MIN_API_VERSION | ||
| self.finch_version = "1.35" # TODO: Update when Finch updates to latest Docker API version |
There was a problem hiding this comment.
This should probably be another variable FINCH_MIN_API_VERSION or something like that to be used in all places, but we can do that separately if we want to push this soon.
There was a problem hiding this comment.
yeah I left it hardcoded bc the Finch team said they would update to the Docker min version soon, so ideally it should just take DOCKER_MIN_API_VERSION
3 participants
Which issue(s) does this change fix?
#8427
Relevant: testcontainers/testcontainers-java#11212
Why is this change necessary?
Docker API has increased their minimum version from 1.24 to 1.44
How does it address the issue?
Updated our docker api version and updated tests.
What side effects does this change have?
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.