Skip to content

feat: add nodejs24.x runtime support#8431

Merged
roger-zhangg merged 3 commits into
aws:developfrom
bnusunny:feat-nodejs24
Nov 19, 2025
Merged

feat: add nodejs24.x runtime support#8431
roger-zhangg merged 3 commits into
aws:developfrom
bnusunny:feat-nodejs24

Conversation

@bnusunny

Copy link
Copy Markdown
Contributor

Which issue(s) does this change fix?

Why is this change necessary?

add nodejs24.x runtime support

How does it address the issue?

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bnusunny
bnusunny requested a review from a team as a code owner November 14, 2025 01:08
@github-actions github-actions Bot added area/local/start-api sam local start-api command area/build sam build command area/local/invoke sam local invoke command area/local/start-invoke area/schema JSON schema file pr/internal labels Nov 14, 2025
@seshubaws

Copy link
Copy Markdown
Contributor

See some tests failing

FAILED tests/integration/buildcmd/test_build_cmd_node.py::TestBuildCommand_EsbuildFunctions::test_building_default_package_json_al2023_4 - AssertionError: 'template.yaml' not found in []
FAILED tests/integration/buildcmd/test_build_cmd_node.py::TestBuildCommand_NodeFunctions_With_External_Manifest::test_building_default_package_json_al2023_2 - AssertionError: 'template.yaml' not found in []
FAILED tests/integration/buildcmd/test_build_cmd_node.py::TestBuildCommand_EsbuildFunctions::test_building_default_package_json_al2023_5 - AssertionError: 'template.yaml' not found in []
FAILED tests/integration/buildcmd/test_build_cmd_node.py::TestBuildCommand_EsbuildFunctions_With_External_Manifest::test_building_default_package_json_5 - AssertionError: 'template.yaml' not found in []
FAILED tests/integration/buildcmd/test_build_cmd_node.py::TestBuildCommand_EsbuildFunctions_With_External_Manifest::test_building_default_package_json_4 - AssertionError: 'template.yaml' not found in []
FAILED tests/integration/buildcmd/test_build_cmd_node.py::TestBuildCommand_EsbuildFunctionProperties_0_esbuild_templates_template_with_metadata_node_options_yaml::test_environment_generates_sourcemap_al2023_4 - FileNotFoundError: [Errno 2] No such file or directory: '/home/runner/work/aws-sam-cli/aws-sam-cli/tests/integration/buildcmd/tmp/e3fc24193b/tmpel9vdl0y/.aws-sam/build/Function'
FAILED tests/integration/buildcmd/test_build_cmd_node.py::TestBuildCommand_EsbuildFunctionProperties_0_esbuild_templates_template_with_metadata_node_options_yaml::test_environment_generates_sourcemap_al2023_5 - FileNotFoundError: [Errno 2] No such file or directory: '/home/runner/work/aws-sam-cli/aws-sam-cli/tests/integration/buildcmd/tmp/285ce64575/tmp8u32b1s6/.aws-sam/build/Function'
FAILED tests/integration/buildcmd/test_build_cmd_node.py::TestBuildCommand_EsbuildFunctionProperties_1_esbuild_templates_template_with_metadata_global_node_options_yaml::test_environment_generates_sourcemap_al2023_4 - FileNotFoundError: [Errno 2] No such file or directory: '/home/runner/work/aws-sam-cli/aws-sam-cli/tests/integration/buildcmd/tmp/aad40c35e5/tmpyje_ns7v/.aws-sam/build/Function'
FAILED tests/integration/buildcmd/test_build_cmd_node.py::TestBuildCommand_EsbuildFunctionProperties_1_esbuild_templates_template_with_metadata_global_node_options_yaml::test_environment_generates_sourcemap_al2023_5 - FileNotFoundError: [Errno 2] No such file or directory: '/home/runner/work/aws-sam-cli/aws-sam-cli/tests/integration/buildcmd/tmp/cc65bbb5e3/tmp_p8lx1h1/.aws-sam/build/Function'
FAILED tests/integration/buildcmd/test_build_cmd_node.py::TestBuildCommand_NodeFunctions_With_Specified_Architecture::test_building_default_package_json_4 - AssertionError: 'template.yaml' not found in []

@bnusunny

Copy link
Copy Markdown
Contributor Author

Yes, these tests fail because the new lambda builder is not released yet.

@roger-zhangg

Copy link
Copy Markdown
Member

LGTM, wait for integ test
https://github.com/aws/aws-sam-cli/actions/runs/19484132668

@roger-zhangg
roger-zhangg added this pull request to the merge queue Nov 19, 2025
Merged via the queue into aws:develop with commit beff7f4 Nov 19, 2025
78 of 100 checks passed
@bnusunny
bnusunny deleted the feat-nodejs24 branch November 19, 2025 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build sam build command area/local/invoke sam local invoke command area/local/start-api sam local start-api command area/local/start-invoke area/schema JSON schema file pr/internal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants