chore(deps-dev): bump types-colorama from 0.4.15.20260408 to 0.4.15.20260508#8968
Conversation
Bumps [types-colorama](https://github.com/python/typeshed) from 0.4.15.20260408 to 0.4.15.20260508. - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-colorama dependency-version: 0.4.15.20260508 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
dependabot
Bot
added
python
aws-sam-cli-bot
left a comment
aws-sam-cli-bot
left a comment
There was a problem hiding this comment.
Code Review Results
Reviewed: 9f13e3d..43f1f0b
Files: 5
Comments: 1
Comments on lines outside the diff:
[requirements/reproducible-linux.txt:81] [GENERAL] This PR is titled and described as a types-colorama dev-dependency patch bump, but the diff also contains unrelated changes that affect runtime behavior:
requirements/reproducible-{linux,mac,win}.txt: downgradesbinaryornotfrom0.6.0to0.4.4(all three files) and addschardet==5.2.0as its new transitive dep.installer/pyinstaller/hook-samcli.py: removes thehooks.collect_all("binaryornot", include_py_files=False)[0]call (and its explanatory comment) that bundlesbinaryornot's data files into the PyInstaller build.
These edits are internally consistent with each other (0.4.4 stores its signature tables as module-level data rather than the binaryornot.data subpackage that 0.6.0 introduced, so the hook is not needed), but they have nothing to do with types-colorama and they impact the PyInstaller-bundled sam init path (via cookiecutter → binaryornot).
This looks like a rebase/merge artifact where the Dependabot branch was not rebased onto the current base before the diff was produced. Please:
- Rebase this branch onto the latest target branch so only the
types-coloramabump remains, or - If the
binaryornotdowngrade and hook removal are intentional, split them into a separate, clearly-described PR so they receive their own review — they should not ride along on an auto-mergeable Dependabot dev-dep bump.
The same unrelated changes appear at:
requirements/reproducible-mac.txt:81requirements/reproducible-win.txt:81installer/pyinstaller/hook-samcli.py:19(removed lines)
vicheey
left a comment
vicheey
left a comment
There was a problem hiding this comment.
Approved: dependabot dependency update.
3 participants
Bumps types-colorama from 0.4.15.20260408 to 0.4.15.20260508.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)