-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: add java8.al2023, java11.al2023, java17.al2023 runtime support #9125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
d34e811
dc72066
9b4295a
c31732d
57f0599
023ec0d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -83,8 +83,15 @@ def compare_runtimes(first_runtime, second_runtime): | |
|
|
||
| if first_runtime_name == second_runtime_name: | ||
| if first_version_number == second_version_number: | ||
| # If it's the same runtime and version return al2 first | ||
| return -1 if first_runtime.endswith(".al2") else 1 | ||
|
|
||
| def _os_variant_rank(r: str) -> int: | ||
|
ckawl marked this conversation as resolved.
|
||
| if r.endswith(".al2023"): | ||
| return 0 | ||
| if r.endswith(".al2"): | ||
| return 1 | ||
| return 2 | ||
|
|
||
| return _os_variant_rank(first_runtime) - _os_variant_rank(second_runtime) | ||
|
Comment on lines
+87
to
+94
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this change the behavior? Say that runtime 1 is java8.al2 and the second is python3.12. In the old version, that would return -1. In the new version, the return is 1 - 0, which is 1.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ig that pair (java8.al2 vs python3.12) never hits this code, since java vs python are different names so it returns on the name comparison. and the java8 without suffix doesn't exist in INIT_RUNTIMES so that situation will never happens either. So for the real pairs (java8.al2 vs java8.al2023, java17 vs java17.al2023), we've flipped to newest-os-first per Renato's feedback. |
||
| return second_version_number - first_version_number | ||
|
|
||
| return 1 if first_runtime_name > second_runtime_name else -1 | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.