Skip to content

Commit 0acb769

Browse files
committed
Fix partition NAME field to preserve public API
1 parent 91c0213 commit 0acb769

3 files changed

Lines changed: 16 additions & 3 deletions

File tree

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"type": "feature",
3-
"category": "AWS SDK for Java v",
3+
"category": "AWS SDK for Java v2",
44
"contributor": "",
55
"description": "Migrate PartitionMetadata code generation from endpoints.json to partitions.json"
66
}

codegen-lite/src/main/java/software/amazon/awssdk/codegen/lite/regions/PartitionMetadataGenerator.java

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,18 @@
4444

4545
public class PartitionMetadataGenerator implements PoetClass {
4646

47+
private static final Map<String, String> PARTITION_DISPLAY_NAMES =
48+
ImmutableMap.<String, String>builder()
49+
.put("aws", "AWS Standard")
50+
.put("aws-cn", "AWS China")
51+
.put("aws-us-gov", "AWS GovCloud (US)")
52+
.put("aws-iso", "AWS ISO (US)")
53+
.put("aws-iso-b", "AWS ISOB (US)")
54+
.put("aws-iso-e", "AWS ISOE (Europe)")
55+
.put("aws-iso-f", "AWS ISOF")
56+
.put("aws-eusc", "AWS EUSC")
57+
.build();
58+
4759
private final PartitionRegionsMetadata partition;
4860
private final String basePackage;
4961
private final String regionBasePackage;
@@ -85,7 +97,8 @@ public TypeSpec poetClass() {
8597
.build())
8698
.addField(FieldSpec.builder(String.class, "NAME")
8799
.addModifiers(PRIVATE, FINAL, STATIC)
88-
.initializer("$S", partition.getOutputs().getName())
100+
.initializer("$S", PARTITION_DISPLAY_NAMES.getOrDefault(
101+
partition.getId(), partition.getId()))
89102
.build())
90103
.addField(FieldSpec.builder(String.class, "REGION_REGEX")
91104
.addModifiers(PRIVATE, FINAL, STATIC)

codegen-lite/src/test/resources/software/amazon/awssdk/codegen/lite/regions/partition-metadata.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public final class AwsPartitionMetadata implements PartitionMetadata {
2828

2929
private static final String ID = "aws";
3030

31-
private static final String NAME = "aws";
31+
private static final String NAME = "AWS Standard";
3232

3333
private static final String REGION_REGEX = "^(us|eu|ap|sa|ca|me|af|il|mx)\\-\\w+\\-\\d+$";
3434

0 commit comments

Comments
 (0)