Skip to content

Commit 13086d7

Browse files
authored
use class-based temporaryBucketName for s3 stability test buckets (#7099)
1 parent 0059ee6 commit 13086d7

5 files changed

Lines changed: 15 additions & 5 deletions

File tree

test/stability-tests/src/it/java/software/amazon/awssdk/stability/tests/s3/S3AsyncWithCrtAsyncHttpClientStabilityTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package software.amazon.awssdk.stability.tests.s3;
22

3+
import static software.amazon.awssdk.testutils.service.S3BucketUtils.temporaryBucketName;
4+
35
import java.time.Duration;
46
import org.junit.jupiter.api.AfterAll;
57
import org.junit.jupiter.api.BeforeAll;
@@ -15,7 +17,7 @@
1517
*/
1618
public class S3AsyncWithCrtAsyncHttpClientStabilityTest extends S3AsyncBaseStabilityTest {
1719

18-
private static String bucketName = "s3withcrtasyncclientstabilitytests" + System.currentTimeMillis();
20+
private static String bucketName = temporaryBucketName(S3AsyncWithCrtAsyncHttpClientStabilityTest.class);
1921

2022
private static S3AsyncClient s3CrtClient;
2123

test/stability-tests/src/it/java/software/amazon/awssdk/stability/tests/s3/S3CrtAsyncClientStabilityTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515

1616
package software.amazon.awssdk.stability.tests.s3;
1717

18+
import static software.amazon.awssdk.testutils.service.S3BucketUtils.temporaryBucketName;
19+
1820
import org.junit.jupiter.api.AfterAll;
1921
import org.junit.jupiter.api.BeforeAll;
2022
import software.amazon.awssdk.crt.CrtResource;
@@ -26,7 +28,7 @@
2628
* Stability tests for {@link S3CrtAsyncClient}
2729
*/
2830
public class S3CrtAsyncClientStabilityTest extends S3AsyncBaseStabilityTest {
29-
private static final String BUCKET_NAME = String.format("s3crtasyncclinetstabilitytests%d", System.currentTimeMillis());
31+
private static final String BUCKET_NAME = temporaryBucketName(S3CrtAsyncClientStabilityTest.class);
3032
private static final S3AsyncClient s3CrtAsyncClient;
3133

3234
static {

test/stability-tests/src/it/java/software/amazon/awssdk/stability/tests/s3/S3CrtClientStabilityTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515

1616
package software.amazon.awssdk.stability.tests.s3;
1717

18+
import static software.amazon.awssdk.testutils.service.S3BucketUtils.temporaryBucketName;
19+
1820
import java.time.Duration;
1921
import java.util.concurrent.Executors;
2022
import java.util.concurrent.TimeUnit;
@@ -32,7 +34,7 @@
3234
* Stability tests for S3 sync client using {@link AwsCrtHttpClient}.
3335
*/
3436
public class S3CrtClientStabilityTest extends S3BaseStabilityTest {
35-
private static final String BUCKET_NAME = String.format("s3crthttpclientstabilitytests%d", System.currentTimeMillis());
37+
private static final String BUCKET_NAME = temporaryBucketName(S3CrtClientStabilityTest.class);
3638

3739
private static final int CRT_CLIENT_THREAD_COUNT;
3840

test/stability-tests/src/it/java/software/amazon/awssdk/stability/tests/s3/S3MultipartJavaBasedStabilityTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515

1616
package software.amazon.awssdk.stability.tests.s3;
1717

18+
import static software.amazon.awssdk.testutils.service.S3BucketUtils.temporaryBucketName;
19+
1820
import java.time.Duration;
1921
import org.junit.jupiter.api.AfterAll;
2022
import org.junit.jupiter.api.BeforeAll;
@@ -23,7 +25,7 @@
2325
import software.amazon.awssdk.services.s3.S3AsyncClient;
2426

2527
public class S3MultipartJavaBasedStabilityTest extends S3AsyncBaseStabilityTest {
26-
private static final String BUCKET_NAME = String.format("s3multipartjavabasedstabilitytest%d", System.currentTimeMillis());
28+
private static final String BUCKET_NAME = temporaryBucketName(S3MultipartJavaBasedStabilityTest.class);
2729
private static final S3AsyncClient multipartJavaBasedClient;
2830

2931
static {

test/stability-tests/src/it/java/software/amazon/awssdk/stability/tests/s3/S3NettyAsyncStabilityTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package software.amazon.awssdk.stability.tests.s3;
22

3+
import static software.amazon.awssdk.testutils.service.S3BucketUtils.temporaryBucketName;
4+
35
import org.junit.jupiter.api.AfterAll;
46
import org.junit.jupiter.api.BeforeAll;
57
import software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClient;
@@ -12,7 +14,7 @@
1214

1315
public class S3NettyAsyncStabilityTest extends S3AsyncBaseStabilityTest {
1416

15-
private static String bucketName = "s3nettyasyncstabilitytests" + System.currentTimeMillis();
17+
private static String bucketName = temporaryBucketName(S3NettyAsyncStabilityTest.class);
1618

1719
private static S3AsyncClient s3NettyClient;
1820

0 commit comments

Comments
 (0)