Skip to content

Commit 344769f

Browse files
dagnirjoviegas
authored andcommitted
Revert to 4.x for test
Expect100ContinueHeaderTest tests 4.x specific behavior (default 100-continue).
1 parent 5bfeb15 commit 344769f

2 files changed

Lines changed: 15 additions & 9 deletions

File tree

services/s3/pom.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,12 @@
203203
<version>${awsjavasdk.version}</version>
204204
<scope>test</scope>
205205
</dependency>
206+
<dependency>
207+
<groupId>software.amazon.awssdk</groupId>
208+
<artifactId>apache-client</artifactId>
209+
<version>${awsjavasdk.version}</version>
210+
<scope>test</scope>
211+
</dependency>
206212
<dependency>
207213
<groupId>software.amazon.awssdk</groupId>
208214
<artifactId>apache5-client</artifactId>

services/s3/src/test/java/software/amazon/awssdk/services/s3/functionaltests/Expect100ContinueHeaderTest.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
import software.amazon.awssdk.http.ContentStreamProvider;
5151
import software.amazon.awssdk.http.SdkHttpClient;
5252
import software.amazon.awssdk.http.SdkHttpConfigurationOption;
53-
import software.amazon.awssdk.http.apache5.Apache5HttpClient;
53+
import software.amazon.awssdk.http.apache.ApacheHttpClient;
5454
import software.amazon.awssdk.http.async.SdkAsyncHttpClient;
5555
import software.amazon.awssdk.http.crt.AwsCrtAsyncHttpClient;
5656
import software.amazon.awssdk.http.crt.AwsCrtHttpClient;
@@ -90,7 +90,7 @@ void setup(WireMockRuntimeInfo wmRuntimeInfo) {
9090
URI endpointOverride = URI.create(wmRuntimeInfo.getHttpsBaseUrl());
9191

9292
syncClient = S3Client.builder()
93-
.httpClient(Apache5HttpClient.builder().buildWithDefaults(trustAllCerts()))
93+
.httpClient(ApacheHttpClient.builder().buildWithDefaults(trustAllCerts()))
9494
.region(Region.US_EAST_1)
9595
.endpointOverride(endpointOverride)
9696
.requestChecksumCalculation(RequestChecksumCalculation.WHEN_REQUIRED)
@@ -359,17 +359,17 @@ private S3Client buildSyncClient(String clientType, WireMockRuntimeInfo wmInfo,
359359
SdkHttpClient httpClient;
360360
switch (clientType) {
361361
case "APACHE":
362-
httpClient = Apache5HttpClient.builder().buildWithDefaults(trustAllCerts());
362+
httpClient = ApacheHttpClient.builder().buildWithDefaults(trustAllCerts());
363363
break;
364364
case "APACHE_EC_ENABLED":
365-
httpClient = Apache5HttpClient.builder()
366-
.expectContinueEnabled(true)
367-
.buildWithDefaults(trustAllCerts());
365+
httpClient = ApacheHttpClient.builder()
366+
.expectContinueEnabled(true)
367+
.buildWithDefaults(trustAllCerts());
368368
break;
369369
case "APACHE_EC_DISABLED":
370-
httpClient = Apache5HttpClient.builder()
371-
.expectContinueEnabled(false)
372-
.buildWithDefaults(trustAllCerts());
370+
httpClient = ApacheHttpClient.builder()
371+
.expectContinueEnabled(false)
372+
.buildWithDefaults(trustAllCerts());
373373
break;
374374
case "URL_CONNECTION":
375375
httpClient = UrlConnectionHttpClient.builder().buildWithDefaults(trustAllCerts());

0 commit comments

Comments
 (0)