Skip to content

Commit 34df128

Browse files
authored
test(sdk-core): Use Flowable.just instead of hand-written mock publisher in FileAsyncResponseTransformerPublisherTest to prevent flaky test failures (#7044)
1 parent c5c423a commit 34df128

1 file changed

Lines changed: 3 additions & 23 deletions

File tree

core/sdk-core/src/test/java/software/amazon/awssdk/core/internal/async/FileAsyncResponseTransformerPublisherTest.java

Lines changed: 3 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import static org.mockito.Mockito.when;
2323

2424
import com.google.common.jimfs.Jimfs;
25+
import io.reactivex.Flowable;
2526
import java.nio.ByteBuffer;
2627
import java.nio.file.FileSystem;
2728
import java.nio.file.Files;
@@ -139,18 +140,7 @@ private void createFileIfNeeded(AsyncResponseTransformer<SdkResponse, SdkRespons
139140
}
140141

141142
private SdkPublisher<ByteBuffer> createMockPublisher() {
142-
return s -> s.onSubscribe(new Subscription() {
143-
@Override
144-
public void request(long n) {
145-
s.onNext(ByteBuffer.wrap("test data".getBytes()));
146-
s.onComplete();
147-
}
148-
149-
@Override
150-
public void cancel() {
151-
// unused for tests
152-
}
153-
});
143+
return SdkPublisher.adapt(Flowable.just(ByteBuffer.wrap("test data".getBytes())));
154144
}
155145

156146
@ParameterizedTest
@@ -256,17 +246,7 @@ private SdkResponse createMockResponseWithRange(String contentRange, Long conten
256246
}
257247

258248
private SdkPublisher<ByteBuffer> createMockPublisherWithData(byte[] data) {
259-
return s -> s.onSubscribe(new Subscription() {
260-
@Override
261-
public void request(long n) {
262-
s.onNext(ByteBuffer.wrap(data));
263-
s.onComplete();
264-
}
265-
266-
@Override
267-
public void cancel() {
268-
}
269-
});
249+
return SdkPublisher.adapt(Flowable.just(ByteBuffer.wrap(data)));
270250
}
271251

272252
private static Stream<Function<Path, AsyncResponseTransformer<SdkResponse, SdkResponse>>> transformers() {

0 commit comments

Comments
 (0)