Handle Junit failures

Author: joviegas

http-clients/aws-crt-client/src/main/java/software/amazon/awssdk/http/crt/internal/response/CrtResponseAdapter.java

@@ -107,6 +107,7 @@ public int onResponseBody(HttpStreamBase stream, byte[] bodyBytesIn) {
 
     @Override
     public void onResponseComplete(HttpStreamBase stream, int errorCode) {
+        responseHandlerHelper.onResponseComplete();
         if (errorCode == CRT.AWS_CRT_SUCCESS) {
             onSuccessfulResponseComplete();
         } else {

http-clients/aws-crt-client/src/main/java/software/amazon/awssdk/http/crt/internal/response/InputStreamAdaptingHttpStreamResponseHandler.java

@@ -109,6 +109,7 @@ public int onResponseBody(HttpStreamBase stream, byte[] bodyBytesIn) {
 
     @Override
     public void onResponseComplete(HttpStreamBase stream, int errorCode) {
+        responseHandlerHelper.onResponseComplete();
         if (errorCode == CRT.AWS_CRT_SUCCESS) {
             onSuccessfulResponseComplete();
         } else {

http-clients/aws-crt-client/src/main/java/software/amazon/awssdk/http/crt/internal/response/ResponseHandlerHelper.java

@@ -32,6 +32,7 @@ public class ResponseHandlerHelper {
     private final SdkHttpResponse.Builder responseBuilder;
     private HttpStreamBase stream;
     private boolean streamClosed;
+    private boolean streamCompleted;
     private final Object streamLock = new Object();
 
     public ResponseHandlerHelper(SdkHttpResponse.Builder responseBuilder) {
@@ -81,16 +82,33 @@ public void releaseConnection() {
         }
     }
 
+    /**
+     * Called when CRT fires onResponseComplete. After this, {@link #closeConnection()} skips
+     * {@code cancel()} to avoid a use-after-free in the native layer: on the GOAWAY path,
+     * {@code thread_data.state} is {@code HALF_CLOSED_LOCAL} (not {@code CLOSED}), so the
+     * cancel cross-thread task's state check passes and dereferences a freed connection → SIGSEGV.
+     */
+    public void onResponseComplete() {
+        synchronized (streamLock) {
+            streamCompleted = true;
+        }
+    }
+
     /**
      * Cancel and close the stream, forcing the underlying connection to shut down rather than be returned to the
      * connection pool. This should be called on error paths or when the stream is aborted before the response is
      * fully consumed. {@code cancel()} must be invoked before {@code close()} per the CRT contract.
+     * <p>
+     * If CRT has already completed the stream via {@link #onResponseComplete()}, {@code cancel()} is skipped
+     * to avoid a native use-after-free, but {@code close()} is still called to release the Java-side handle.
      */
     public void closeConnection() {
         synchronized (streamLock) {
             if (!streamClosed && stream != null) {
                 streamClosed = true;
-                stream.cancel();
+                if (!streamCompleted) {
+                    stream.cancel();
+                }
                 stream.close();
             }
         }

http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/internal/BaseHttpStreamResponseHandlerTest.java

@@ -91,15 +91,18 @@ void nonServerError_shouldCloseStream(int statusCode) {
     }
 
     @Test
-    void failedToGetResponse_shouldCancelAndCloseStream() {
+    void failedToGetResponse_shouldCloseStreamWithoutCancel() {
         HttpHeader[] httpHeaders = getHttpHeaders();
         responseHandler.onResponseHeaders(httpStream, 200, HttpHeaderBlock.MAIN.getValue(),
                                           httpHeaders);
 
         responseHandler.onResponseComplete(httpStream, 1);
         assertThatThrownBy(() -> requestFuture.join()).hasRootCauseInstanceOf(HttpException.class);
         InOrder inOrder = Mockito.inOrder(httpStream);
-        inOrder.verify(httpStream).cancel();
+        // cancel() is skipped when CRT has already completed the stream (streamCompleted=true).
+        // Per HttpStreamBase.cancel() javadoc: "if the stream is already completing, this call will have no effect."
+        // For HTTP/2, calling cancel() on an already-completed stream triggers premature native resource cleanup.
+        verify(httpStream, never()).cancel();
         inOrder.verify(httpStream).close();
     }