Skip to content

Commit 558ac66

Browse files
committed
Fixing failing tests
1 parent d577caa commit 558ac66

4 files changed

Lines changed: 25 additions & 9 deletions

File tree

codegen/src/main/java/software/amazon/awssdk/codegen/poet/auth/scheme/AuthSchemeInterceptorSpec.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -163,9 +163,13 @@ private MethodSpec generateBeforeExecution() {
163163
builder.beginControlFlow("if (selectedAuthScheme != null && "
164164
+ "selectedAuthScheme.authSchemeOption().schemeId().equals($S))",
165165
"aws.auth#sigv4a")
166-
.addStatement("executionAttributes.getAttribute($T.BUSINESS_METRICS)"
167-
+ ".addMetric($T.SIGV4A_SIGNING.value())",
168-
SdkInternalExecutionAttribute.class, BusinessMetricFeatureId.class)
166+
.addStatement("$T businessMetrics = executionAttributes.getAttribute($T.BUSINESS_METRICS)",
167+
ClassName.get("software.amazon.awssdk.core.useragent", "BusinessMetricCollection"),
168+
SdkInternalExecutionAttribute.class)
169+
.beginControlFlow("if (businessMetrics != null)")
170+
.addStatement("businessMetrics.addMetric($T.SIGV4A_SIGNING.value())",
171+
BusinessMetricFeatureId.class)
172+
.endControlFlow()
169173
.endControlFlow();
170174
}
171175
return builder.build();

codegen/src/test/resources/software/amazon/awssdk/codegen/poet/auth/scheme/ops-auth-sigv4a-value-auth-scheme-interceptor.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import software.amazon.awssdk.core.interceptor.SdkInternalExecutionAttribute;
2121
import software.amazon.awssdk.core.internal.util.MetricUtils;
2222
import software.amazon.awssdk.core.metrics.CoreMetric;
23+
import software.amazon.awssdk.core.useragent.BusinessMetricCollection;
2324
import software.amazon.awssdk.core.useragent.BusinessMetricFeatureId;
2425
import software.amazon.awssdk.http.auth.aws.signer.RegionSet;
2526
import software.amazon.awssdk.http.auth.spi.scheme.AuthScheme;
@@ -51,8 +52,11 @@ public void beforeExecution(Context.BeforeExecution context, ExecutionAttributes
5152
SelectedAuthScheme<? extends Identity> selectedAuthScheme = selectAuthScheme(authOptions, executionAttributes);
5253
putSelectedAuthScheme(executionAttributes, selectedAuthScheme);
5354
if (selectedAuthScheme != null && selectedAuthScheme.authSchemeOption().schemeId().equals("aws.auth#sigv4a")) {
54-
executionAttributes.getAttribute(SdkInternalExecutionAttribute.BUSINESS_METRICS).addMetric(
55-
BusinessMetricFeatureId.SIGV4A_SIGNING.value());
55+
BusinessMetricCollection businessMetrics = executionAttributes
56+
.getAttribute(SdkInternalExecutionAttribute.BUSINESS_METRICS);
57+
if (businessMetrics != null) {
58+
businessMetrics.addMetric(BusinessMetricFeatureId.SIGV4A_SIGNING.value());
59+
}
5660
}
5761
}
5862

codegen/src/test/resources/software/amazon/awssdk/codegen/poet/auth/scheme/query-endpoint-auth-params-with-allowlist-auth-scheme-interceptor.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import software.amazon.awssdk.core.interceptor.SdkInternalExecutionAttribute;
2121
import software.amazon.awssdk.core.internal.util.MetricUtils;
2222
import software.amazon.awssdk.core.metrics.CoreMetric;
23+
import software.amazon.awssdk.core.useragent.BusinessMetricCollection;
2324
import software.amazon.awssdk.core.useragent.BusinessMetricFeatureId;
2425
import software.amazon.awssdk.endpoints.EndpointProvider;
2526
import software.amazon.awssdk.http.auth.aws.signer.RegionSet;
@@ -54,8 +55,11 @@ public void beforeExecution(Context.BeforeExecution context, ExecutionAttributes
5455
SelectedAuthScheme<? extends Identity> selectedAuthScheme = selectAuthScheme(authOptions, executionAttributes);
5556
putSelectedAuthScheme(executionAttributes, selectedAuthScheme);
5657
if (selectedAuthScheme != null && selectedAuthScheme.authSchemeOption().schemeId().equals("aws.auth#sigv4a")) {
57-
executionAttributes.getAttribute(SdkInternalExecutionAttribute.BUSINESS_METRICS).addMetric(
58-
BusinessMetricFeatureId.SIGV4A_SIGNING.value());
58+
BusinessMetricCollection businessMetrics = executionAttributes
59+
.getAttribute(SdkInternalExecutionAttribute.BUSINESS_METRICS);
60+
if (businessMetrics != null) {
61+
businessMetrics.addMetric(BusinessMetricFeatureId.SIGV4A_SIGNING.value());
62+
}
5963
}
6064
}
6165

codegen/src/test/resources/software/amazon/awssdk/codegen/poet/auth/scheme/query-endpoint-auth-params-without-allowlist-auth-scheme-interceptor.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import software.amazon.awssdk.core.interceptor.SdkInternalExecutionAttribute;
2121
import software.amazon.awssdk.core.internal.util.MetricUtils;
2222
import software.amazon.awssdk.core.metrics.CoreMetric;
23+
import software.amazon.awssdk.core.useragent.BusinessMetricCollection;
2324
import software.amazon.awssdk.core.useragent.BusinessMetricFeatureId;
2425
import software.amazon.awssdk.endpoints.EndpointProvider;
2526
import software.amazon.awssdk.http.auth.aws.signer.RegionSet;
@@ -54,8 +55,11 @@ public void beforeExecution(Context.BeforeExecution context, ExecutionAttributes
5455
SelectedAuthScheme<? extends Identity> selectedAuthScheme = selectAuthScheme(authOptions, executionAttributes);
5556
putSelectedAuthScheme(executionAttributes, selectedAuthScheme);
5657
if (selectedAuthScheme != null && selectedAuthScheme.authSchemeOption().schemeId().equals("aws.auth#sigv4a")) {
57-
executionAttributes.getAttribute(SdkInternalExecutionAttribute.BUSINESS_METRICS).addMetric(
58-
BusinessMetricFeatureId.SIGV4A_SIGNING.value());
58+
BusinessMetricCollection businessMetrics = executionAttributes
59+
.getAttribute(SdkInternalExecutionAttribute.BUSINESS_METRICS);
60+
if (businessMetrics != null) {
61+
businessMetrics.addMetric(BusinessMetricFeatureId.SIGV4A_SIGNING.value());
62+
}
5963
}
6064
}
6165

0 commit comments

Comments
 (0)