writeTo_ConcurrentWrites_HandlesCorrectly no longer needed since even Apache 4.x doesnot suports this

Author: joviegas

http-clients/apache-client/src/test/java/software/amazon/awssdk/http/apache/internal/RepeatableInputStreamRequestEntityTest.java

@@ -36,12 +36,7 @@
 import java.io.InputStream;
 import java.io.InterruptedIOException;
 import java.net.URI;
-import java.util.ArrayList;
-import java.util.Collections;
-import java.util.List;
 import java.util.Random;
-import java.util.concurrent.CountDownLatch;
-import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicInteger;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.DisplayName;
@@ -344,7 +339,9 @@ public int read() throws IOException {
                     return -1;
                 }
                 hasBeenRead = true;
-                return data[position++] & 0xFF;
+                int i = data[position] & 0xFF;
+                position++;
+                return i;
             }
 
             @Override
@@ -671,51 +668,6 @@ void constructor_WithoutContentType_HandlesGracefully() {
         assertEquals(100L, entity.getContentLength());
     }
 
-    @Test
-    @DisplayName("Entity should handle concurrent write attempts")
-    void writeTo_ConcurrentWrites_HandlesCorrectly() throws Exception {
-        // Given
-        String content = "Concurrent test content";
-        ContentStreamProvider provider = () -> new ByteArrayInputStream(content.getBytes());
-        SdkHttpRequest httpRequest = httpRequestBuilder.build();
-        HttpExecuteRequest request = HttpExecuteRequest.builder()
-                                                       .request(httpRequest)
-                                                       .contentStreamProvider(provider)
-                                                       .build();
-
-        entity = new RepeatableInputStreamRequestEntity(request);
-
-        // Simulate concurrent writes
-        int threadCount = 5;
-        CountDownLatch latch = new CountDownLatch(threadCount);
-        List<ByteArrayOutputStream> outputs = Collections.synchronizedList(new ArrayList<>());
-        List<Exception> exceptions = Collections.synchronizedList(new ArrayList<>());
-
-        for (int i = 0; i < threadCount; i++) {
-            new Thread(() -> {
-                try {
-                    ByteArrayOutputStream output = new ByteArrayOutputStream();
-                    entity.writeTo(output);
-                    outputs.add(output);
-                } catch (Exception e) {
-                    exceptions.add(e);
-                } finally {
-                    latch.countDown();
-                }
-            }).start();
-        }
-
-        latch.await(5, TimeUnit.SECONDS);
-
-        // At least one should succeed, others may fail due to stream state
-        assertFalse(outputs.isEmpty(), "At least one write should succeed");
-        for (ByteArrayOutputStream output : outputs) {
-            if (output.size() > 0) {
-                assertEquals(content, output.toString());
-            }
-        }
-    }
-
     @Test
     @DisplayName("Entity should handle interrupted IO operations")
     void writeTo_InterruptedStream_ThrowsIOException() throws IOException {
@@ -882,7 +834,7 @@ public boolean markSupported() {
             }
 
             @Override
-            public synchronized void reset()  {
+            public synchronized void reset() {
                 resetCalls.incrementAndGet();
                 throw new RuntimeException("Reset not supported");
             }

http-clients/apache5-client/src/test/java/software/amazon/awssdk/http/apache5/internal/RepeatableInputStreamRequestEntityTest.java

@@ -36,12 +36,7 @@
 import java.io.InputStream;
 import java.io.InterruptedIOException;
 import java.net.URI;
-import java.util.ArrayList;
-import java.util.Collections;
-import java.util.List;
 import java.util.Random;
-import java.util.concurrent.CountDownLatch;
-import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicInteger;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.DisplayName;
@@ -671,51 +666,6 @@ void constructor_WithoutContentType_HandlesGracefully() {
         assertEquals(100L, entity.getContentLength());
     }
 
-    @Test
-    @DisplayName("Entity should handle concurrent write attempts")
-    void writeTo_ConcurrentWrites_HandlesCorrectly() throws Exception {
-        // Given
-        String content = "Concurrent test content";
-        ContentStreamProvider provider = () -> new ByteArrayInputStream(content.getBytes());
-        SdkHttpRequest httpRequest = httpRequestBuilder.build();
-        HttpExecuteRequest request = HttpExecuteRequest.builder()
-                                                       .request(httpRequest)
-                                                       .contentStreamProvider(provider)
-                                                       .build();
-
-        entity = new RepeatableInputStreamRequestEntity(request);
-
-        // Simulate concurrent writes
-        int threadCount = 5;
-        CountDownLatch latch = new CountDownLatch(threadCount);
-        List<ByteArrayOutputStream> outputs = Collections.synchronizedList(new ArrayList<>());
-        List<Exception> exceptions = Collections.synchronizedList(new ArrayList<>());
-
-        for (int i = 0; i < threadCount; i++) {
-            new Thread(() -> {
-                try {
-                    ByteArrayOutputStream output = new ByteArrayOutputStream();
-                    entity.writeTo(output);
-                    outputs.add(output);
-                } catch (Exception e) {
-                    exceptions.add(e);
-                } finally {
-                    latch.countDown();
-                }
-            }).start();
-        }
-
-        latch.await(5, TimeUnit.SECONDS);
-
-        // At least one should succeed, others may fail due to stream state
-        assertFalse(outputs.isEmpty(), "At least one write should succeed");
-        for (ByteArrayOutputStream output : outputs) {
-            if (output.size() > 0) {
-                assertEquals(content, output.toString());
-            }
-        }
-    }
-
     @Test
     @DisplayName("Entity should handle interrupted IO operations")
     void writeTo_InterruptedStream_ThrowsIOException() throws IOException {
@@ -880,7 +830,7 @@ public boolean markSupported() {
             }
 
             @Override
-            public synchronized void reset()  {
+            public synchronized void reset() {
                 resetCalls.incrementAndGet();
                 throw new RuntimeException("Reset not supported");
             }