Skip to content

Commit 60cba9f

Browse files
authored
Merge branch 'master' into zoewang/backfillChangelogEntry
2 parents d8529af + 874fd6a commit 60cba9f

2 files changed

Lines changed: 10 additions & 2 deletions

File tree

services/s3/src/test/java/software/amazon/awssdk/services/s3/internal/multipart/MultipartClientChecksumTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,8 @@ public static void teardown() throws IOException {
100100
wireMock.stop();
101101
}
102102

103-
@ParameterizedTest
103+
// TODO - re-enable after S3 feature release
104+
/*@ParameterizedTest
104105
@MethodSource("checksumAlgorithmParams")
105106
public void multipartUpload_withChecksumAlgorithmAndNoChecksumValueProvided_shouldNotAddChecksumType(ChecksumAlgorithm checksumAlgorithm) {
106107
stubSuccessfulResponses();
@@ -113,7 +114,7 @@ public void multipartUpload_withChecksumAlgorithmAndNoChecksumValueProvided_shou
113114
assertThat(checksumCapturingInterceptor.createMpuChecksumType).isNull();
114115
assertThat(checksumCapturingInterceptor.completeMpuChecksumType).isNull();
115116
assertThat(checksumCapturingInterceptor.completeMpuMpObjectSize).isEqualTo(FILE_SIZE);
116-
}
117+
}*/
117118

118119
// TODO - re-enable after S3 feature release
119120
/*@ParameterizedTest

test/stability-tests/src/it/java/software/amazon/awssdk/stability/tests/s3/S3MockStabilityTestBase.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import java.util.concurrent.CompletableFuture;
2121
import java.util.function.IntFunction;
2222
import org.apache.commons.lang3.RandomStringUtils;
23+
import org.junit.jupiter.api.BeforeAll;
2324
import software.amazon.awssdk.core.async.AsyncRequestBody;
2425
import software.amazon.awssdk.services.s3.S3AsyncClient;
2526
import software.amazon.awssdk.services.s3.model.ChecksumAlgorithm;
@@ -37,6 +38,12 @@ public abstract class S3MockStabilityTestBase {
3738
private static final Logger log = Logger.loggerFor(S3MockStabilityTestBase.class);
3839
MockAsyncHttpClient mockAsyncHttpClient;
3940
S3AsyncClient testClient;
41+
42+
@BeforeAll
43+
public static void init() {
44+
CHECKSUM_ALGORITHMS.remove(ChecksumAlgorithm.valueOf("MD5"));
45+
}
46+
4047
@RetryableTest(maxRetries = 3, retryableException = StabilityTestsRetryableException.class)
4148
public void putObject_Checksum() {
4249
putObjectChecksumVariations();

0 commit comments

Comments
 (0)