Merge pull request #4810 from aws/fix-cachedsupplier-maxStaleFailureJitter

davidh44 · web-flow · commit 81d0e878a0a9 · 2026-03-20T10:34:31.000-07:00
Fix CachedSupplier.maxStaleFailureJitter()
diff --git a/utils/src/main/java/software/amazon/awssdk/utils/cache/CachedSupplier.java b/utils/src/main/java/software/amazon/awssdk/utils/cache/CachedSupplier.java
@@ -335,6 +335,9 @@ private Duration maxPrefetchJitter(RefreshResult<T> result) {
 
     private Duration maxStaleFailureJitter(int numFailures) {
         long exponentialBackoffMillis = (1L << numFailures - 1) * 100;
+        if (exponentialBackoffMillis <= 0) {
+            exponentialBackoffMillis = Long.MAX_VALUE;
+        }
         return ComparableUtils.minimum(Duration.ofMillis(exponentialBackoffMillis), Duration.ofSeconds(10));
     }
 

Original file line number	Diff line number	Diff line change
`@@ -335,6 +335,9 @@ private Duration maxPrefetchJitter(RefreshResult<T> result) {`
`335`	`335`
`336`	`336`	`private Duration maxStaleFailureJitter(int numFailures) {`
`337`	`337`	`long exponentialBackoffMillis = (1L << numFailures - 1) * 100;`
	`338`	`+ if (exponentialBackoffMillis <= 0) {`
	`339`	`+ exponentialBackoffMillis = Long.MAX_VALUE;`
	`340`	`+ }`
`338`	`341`	`return ComparableUtils.minimum(Duration.ofMillis(exponentialBackoffMillis), Duration.ofSeconds(10));`
`339`	`342`	`}`
`340`	`343`