Fix checkstyle, start adding tests

Author: alextwoods

core/sdk-core/src/main/java/software/amazon/awssdk/core/async/AsyncRequestBody.java

@@ -37,7 +37,6 @@
 import software.amazon.awssdk.core.internal.async.InputStreamWithExecutorAsyncRequestBody;
 import software.amazon.awssdk.core.internal.async.SplittingPublisher;
 import software.amazon.awssdk.core.internal.util.Mimetype;
-import software.amazon.awssdk.core.sync.ResponseTransformer;
 import software.amazon.awssdk.utils.BinaryUtils;
 import software.amazon.awssdk.utils.Validate;
 import software.amazon.awssdk.utils.internal.EnumUtils;
@@ -541,12 +540,12 @@ enum BodyType {
         PUBLISHER("Publisher", "p"),
         UNKNOWN("Unknown", "u");
 
-        private final String name;
-        private final String shortValue;
-
         private static final Map<String, BodyType> VALUE_MAP =
             EnumUtils.uniqueIndex(BodyType.class, BodyType::getName);
 
+        private final String name;
+        private final String shortValue;
+
         BodyType(String name, String shortValue) {
             this.name = name;
             this.shortValue = shortValue;

core/sdk-core/src/main/java/software/amazon/awssdk/core/async/AsyncResponseTransformer.java

@@ -391,12 +391,12 @@ enum TransformerType {
         PUBLISHER("Publisher", "p"),
         UNKNOWN("Unknown", "u");
 
-        private final String name;
-        private final String shortValue;
-
         private static final Map<String, TransformerType> VALUE_MAP =
             EnumUtils.uniqueIndex(TransformerType.class, TransformerType::getName);
 
+        private final String name;
+        private final String shortValue;
+
         TransformerType(String name, String shortValue) {
             this.name = name;
             this.shortValue = shortValue;

core/sdk-core/src/main/java/software/amazon/awssdk/core/sync/ResponseTransformer.java

@@ -37,7 +37,6 @@
 import software.amazon.awssdk.core.internal.http.InterruptMonitor;
 import software.amazon.awssdk.core.retry.RetryPolicy;
 import software.amazon.awssdk.http.AbortableInputStream;
-import software.amazon.awssdk.http.ContentStreamProvider;
 import software.amazon.awssdk.utils.IoUtils;
 import software.amazon.awssdk.utils.Logger;
 import software.amazon.awssdk.utils.internal.EnumUtils;
@@ -291,11 +290,12 @@ enum TransformerType {
         STREAM("Stream", "s"),
         UNKNOWN("Unknown", "u");
 
+        private static final Map<String, TransformerType> VALUE_MAP =
+            EnumUtils.uniqueIndex(TransformerType.class, TransformerType::getName);
+
         private final String name;
         private final String shortValue;
 
-        private static final Map<String, TransformerType> VALUE_MAP =
-            EnumUtils.uniqueIndex(TransformerType.class, TransformerType::getName);
 
         TransformerType(String name, String shortValue) {
             this.name = name;

core/sdk-core/src/test/java/software/amazon/awssdk/core/useragent/AdditionalMetadataTest.java

@@ -0,0 +1,41 @@
+/*
+ * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License").
+ * You may not use this file except in compliance with the License.
+ * A copy of the License is located at
+ *
+ *  http://aws.amazon.com/apache2.0
+ *
+ * or in the "license" file accompanying this file. This file is distributed
+ * on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
+ * express or implied. See the License for the specific language governing
+ * permissions and limitations under the License.
+ */
+
+package software.amazon.awssdk.core.useragent;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import nl.jqno.equalsverifier.EqualsVerifier;
+import org.junit.jupiter.api.Test;
+
+public class AdditionalMetadataTest {
+
+    @Test
+    public void toString_formatsCorrectly() {
+        AdditionalMetadata metadata = AdditionalMetadata.builder()
+            .name("name")
+            .value("value")
+                                                        .build();
+        assertEquals("md/name#value", metadata.toString());
+    }
+    @Test
+    public void equalsHashCode() {
+        EqualsVerifier.forClass(AdditionalMetadata.class)
+                      .withNonnullFields("name", "value")
+                      .verify();
+    }
+}
+
+

http-client-spi/src/main/java/software/amazon/awssdk/http/ContentStreamProvider.java

@@ -24,7 +24,6 @@
 import java.util.Arrays;
 import java.util.Map;
 import java.util.function.Supplier;
-import software.amazon.awssdk.annotations.SdkInternalApi;
 import software.amazon.awssdk.annotations.SdkProtectedApi;
 import software.amazon.awssdk.annotations.SdkPublicApi;
 import software.amazon.awssdk.utils.IoUtils;
@@ -185,11 +184,12 @@ enum ProviderType {
         STREAM("Stream", "s"),
         UNKNOWN("Unknown", "u");
 
+        private static final Map<String, ProviderType> VALUE_MAP =
+            EnumUtils.uniqueIndex(ProviderType.class, ProviderType::getName);
+
         private final String name;
         private final String shortValue;
 
-        private static final Map<String, ProviderType> VALUE_MAP =
-            EnumUtils.uniqueIndex(ProviderType.class, ProviderType::getName);
 
         ProviderType(String name, String shortValue) {
             this.name = name;