Skip to content

Commit caf1802

Browse files
committed
Remove redundant import add/remove
1 parent 9d3b407 commit caf1802

2 files changed

Lines changed: 0 additions & 16 deletions

File tree

v2-migration/src/main/java/software/amazon/awssdk/v2migration/S3PojoToV2.java

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
import org.openrewrite.java.AddImport;
2727
import org.openrewrite.java.JavaTemplate;
2828
import org.openrewrite.java.JavaVisitor;
29-
import org.openrewrite.java.RemoveImport;
3029
import org.openrewrite.java.tree.Expression;
3130
import org.openrewrite.java.tree.J;
3231
import org.openrewrite.java.tree.JavaType;
@@ -64,10 +63,7 @@ public J visitNewClass(J.NewClass newClass, ExecutionContext executionContext) {
6463
}
6564

6665
if (type.isAssignableFrom(COMPETE_MPU) && newClass.getArguments().size() == 4) {
67-
addV2S3ModelImport("CompleteMultipartUploadRequest");
6866
addV2S3ModelImport("CompletedMultipartUpload");
69-
removeV1S3ModelImport("CompleteMultipartUploadRequest");
70-
7167
List<Expression> params = newClass.getArguments();
7268
String v2Builder = "CompleteMultipartUploadRequest.builder().bucket(#{any()}).key(#{any()}).uploadId(#{any()})"
7369
+ ".multipartUpload(CompletedMultipartUpload.builder().parts(#{any()}).build()).build()";
@@ -76,18 +72,12 @@ public J visitNewClass(J.NewClass newClass, ExecutionContext executionContext) {
7672
params.get(0), params.get(1), params.get(2), params.get(3));
7773
}
7874
if (type.isAssignableFrom(OBJECT_TAGGING) && newClass.getArguments().size() == 1) {
79-
addV2S3ModelImport("Tagging");
80-
removeV1S3ModelImport("ObjectTagging");
81-
8275
String v2Builder = "Tagging.builder().tagSet(#{any()}).build();";
8376
return JavaTemplate.builder(v2Builder)
8477
.build().apply(getCursor(), newClass.getCoordinates().replace(),
8578
newClass.getArguments().get(0));
8679
}
8780
if (type.isAssignableFrom(GET_OBJECT_TAGGING_RESULT) && newClass.getArguments().size() == 1) {
88-
addV2S3ModelImport("GetObjectTaggingResponse");
89-
removeV1S3ModelImport("GetObjectTaggingResponse");
90-
9181
String v2Builder = "GetObjectTaggingResponse.builder().tagSet(#{any()}).build();";
9282
return JavaTemplate.builder(v2Builder)
9383
.build().apply(getCursor(), newClass.getCoordinates().replace(),
@@ -97,10 +87,6 @@ public J visitNewClass(J.NewClass newClass, ExecutionContext executionContext) {
9787
return super.visitNewClass(newClass, executionContext);
9888
}
9989

100-
private void removeV1S3ModelImport(String className) {
101-
doAfterVisit(new RemoveImport<>(V1_S3_MODEL_PKG + className, true));
102-
}
103-
10490
private void addV2S3ModelImport(String className) {
10591
doAfterVisit(new AddImport<>(V2_S3_MODEL_PKG + className, null, false));
10692
}

v2-migration/src/main/java/software/amazon/awssdk/v2migration/SdkExceptionToV2.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,4 @@ public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, Execu
9191
return super.visitMethodInvocation(method, executionContext);
9292
}
9393
}
94-
95-
9694
}

0 commit comments

Comments
 (0)