PR comments - keep transformerCount in FileAsyncResponseTransformerPublisher

Author: L-Applin

core/sdk-core/src/main/java/software/amazon/awssdk/core/internal/async/FileAsyncResponseTransformer.java

@@ -303,9 +303,7 @@ public String toString() {
     @Override
     public SplitResult<ResponseT, ResponseT> split(SplittingTransformerConfiguration splitConfig) {
         if (configuration.fileWriteOption() == CREATE_OR_APPEND_TO_EXISTING) {
-            return AsyncResponseTransformer.super
-                .split(splitConfig)
-                .copy(res -> res.supportsNonSerial(false));
+            return AsyncResponseTransformer.super.split(splitConfig);
         }
         CompletableFuture<ResponseT> future = new CompletableFuture<>();
         return (SplitResult<ResponseT, ResponseT>) SplitResult.<ResponseT, ResponseT>builder()

services/s3/src/test/java/software/amazon/awssdk/services/s3/internal/multipart/NonLinearMultipartDownloaderSubscriberWiremockTest.java

@@ -68,6 +68,8 @@ public void init(WireMockRuntimeInfo wiremock) throws Exception {
         utils = new MultipartDownloadTestUtils(testBucket, testKey, "test-etag");
         fileSystem = Jimfs.newFileSystem(Configuration.unix());
         testFile = fileSystem.getPath("/test-file.txt");
+        Files.createDirectories(testFile.getParent());
+        Files.createFile(testFile);
     }
 
     @AfterEach

services/s3/src/test/java/software/amazon/awssdk/services/s3/internal/multipart/S3MultipartClientGetObjectWiremockTest.java

@@ -147,8 +147,9 @@ public <T> void errorOnThirdPart_shouldCompleteExceptionallyOnlyPartsGreaterThan
         }
     }
 
-    @ParameterizedTest
-    @MethodSource("partSizeAndTransformerParams")
+    // todo temporary, remove when support for resume is added to multipart file download
+    // @ParameterizedTest
+    // @MethodSource("partSizeAndTransformerParams")
     public <T> void partCountValidationFailure_shouldThrowException(
         AsyncResponseTransformerTestSupplier<T> supplier,
         int partSize) {
@@ -302,8 +303,7 @@ private static Stream<Arguments> partSizeAndTransformerParams() {
      */
     private static Stream<AsyncResponseTransformerTestSupplier<?>> nonRetryableResponseTransformers() {
         return Stream.of(new AsyncResponseTransformerTestSupplier.InputStreamArtSupplier(),
-                         new AsyncResponseTransformerTestSupplier.PublisherArtSupplier(),
-                         new AsyncResponseTransformerTestSupplier.FileArtSupplier());
+                         new AsyncResponseTransformerTestSupplier.PublisherArtSupplier());
     }
 
     private CompletableFuture<?> mock200Response(S3AsyncClient s3Client, int runNumber,

services/s3/src/test/java/software/amazon/awssdk/services/s3/internal/multipart/S3MultipartFileDownloadWiremockTest.java

@@ -77,6 +77,8 @@ public void init(WireMockRuntimeInfo wiremock) throws Exception {
         util = new MultipartDownloadTestUtils(testBucket, testKey, "test-etag");
         fileSystem = Jimfs.newFileSystem(Configuration.unix());
         testFile = fileSystem.getPath("/test-file.txt");
+        Files.createDirectories(testFile.getParent());
+        Files.createFile(testFile);
     }
 
     @AfterEach