Review comments

Author: dagnir

core/http-auth-aws/src/test/java/software/amazon/awssdk/http/auth/aws/crt/internal/signer/DefaultAwsCrtV4aHttpSignerTest.java

@@ -446,8 +446,9 @@ void sign_withProvidedHostHeader_shouldRespectUserHostHeader() {
 
     @Test
     @Disabled("Broken - We don't pass x-amz-content-sha256 to CRT signer")
-    // This is currently broken because we don't preserve the 'x-amz-content-sha256' header when sending to CRT to sign:
+    // TODO: This is currently broken because we don't preserve the 'x-amz-content-sha256' header when sending to CRT to sign:
     // https://github.com/aws/aws-sdk-java-v2/blob/59e3a000503e1299675698e5c4c7af51f2525669/core/http-auth-aws/src/main/java/software/amazon/awssdk/http/auth/aws/crt/internal/util/CrtUtils.java#L45
+    // Refer to JAVA-8531
     void sign_WithPayloadSigningTrue_chunkEncodingFalse_cacheContainsChecksum_usesCachedValue() {
         PayloadChecksumStore cache = PayloadChecksumStore.create();
 
@@ -545,9 +546,6 @@ void sign_withPayloadSigningTrue_chunkEncodingFalse_withChecksum_cacheContainsCr
         byte[] crc32Value = "my-crc32-checksum".getBytes(StandardCharsets.UTF_8);
         cache.putChecksumValue(CRC32, crc32Value);
 
-        // byte[] sha256Value = "my-sha256-checksum".getBytes(StandardCharsets.UTF_8);
-        // cache.putChecksumValue(SHA256, sha256Value);
-
         SignRequest<? extends AwsCredentialsIdentity> request = generateBasicRequest(
             AwsCredentialsIdentity.create("access", "secret"),
             httpRequest -> httpRequest.uri(URI.create("http://demo.us-east-1.amazonaws.com")),
@@ -562,7 +560,6 @@ void sign_withPayloadSigningTrue_chunkEncodingFalse_withChecksum_cacheContainsCr
 
         SdkHttpRequest httpRequest = signedRequest.request();
 
-        // assertThat(httpRequest.firstMatchingHeader("x-amz-content-sha256")).hasValue(BinaryUtils.toHex(sha256Value));
         assertThat(httpRequest.firstMatchingHeader("x-amz-checksum-crc32")).hasValue(BinaryUtils.toBase64(crc32Value));
     }
 

services/s3/src/test/java/software/amazon/awssdk/services/s3/checksums/ChecksumReuseTest.java

@@ -134,7 +134,7 @@ public void abort() {
     }
 
     /**
-     * A stream that randomly returns other 'a' or 'b' from each read() invocation.
+     * A stream that randomly returns either 'a' or 'b' from each read() invocation.
      */
     private static class RandomInputStream extends InputStream {
         private final Random rng = new Random();