Add a mechanism to identify a service from its Builder (without reflection)

[abatkin]

Describe the feature

There should be a way to uniquely identify a service from its Builder. Direct reflection on the Builder's class or interfaces is heavy handed and cumbersome. In the interim, we have been successfully using reflection to make accessible and call the protected method AwsDefaultClientBuilder.serviceName(). The serviceEndpointPrefix() method would work equally well.

Use Case

We have service-specific configuration settings that we apply in a generic way using SdkBuilder.applyMutation(). For example, under certain circumstances, some services need to use one of two different proxy clusters or no proxy server at all. But part of this determination requires that we know what service it is.

Proposed Solution

Hoist serviceEndpointPrefix() and/or serviceName() from AwsDefaultClientBuilder into an interface like AwsClientBuilder.

Other Information

I haven't really thought through all the implications of moving those methods to AwsClientBuilder (or to another interface, or just making the abstract class's methods public). Or whether there's a better way altogether. But I can say that we have been successfully using serviceName() for many years, and it would be nice to make this (or something equivalent) better/officially supported.

So let's start the discussion here.

Acknowledgements

• I may be able to implement this feature request
• This feature might incur a breaking change

AWS Java SDK version used

All

JDK version used

All

Operating System and version

All

[debora-ito]

Hi @abatkin, discussed with the team, and right now we don't have plans to add such mechanism, and we also don't know the impact of making the protected method public without doing some deep dive research.

For now we'll keep this feature request open to gather upvotes from the community. If anyone would like to see this supported, please add a 👍 in the top description.

[abatkin]

@debora-ito Do you have a supported workaround?

The main use case: We need to apply service-specific configurations, and configuration always needs to happen at the Builder level. How do we do that?

As far as "the impact of making the protected methods public", generally that kind of change has no impact (other than that you are adding something to the public API which now needs to be supported). You could even just add a getter for serviceName and serviceEndpointPrefix. I'm happy to put together a PR, if you think it has a chance of being accepted.