Add duplicateAndRenameSharedEvents customization to support event shapes shared with multiple evenstreams#6031
Merged
alextwoods merged 8 commits intomasterfrom Aug 18, 2025
Conversation
|
alextwoods
commented
Apr 21, 2025
...sdk/codegen/emitters/customizations/processors/uselegacyeventgenerationscheme/service-2.json
Show resolved
Hide resolved
9 tasks
Fred1155
reviewed
Aug 14, 2025
...software/amazon/awssdk/codegen/customization/processors/EventStreamSharedEventProcessor.java
Outdated
Show resolved
Hide resolved
Fred1155
approved these changes
Aug 15, 2025
|
RanVaknin
requested changes
Aug 15, 2025
...software/amazon/awssdk/codegen/customization/processors/EventStreamSharedEventProcessor.java
Show resolved
Hide resolved
RanVaknin
approved these changes
Aug 15, 2025
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Add processor to detect shared events + customization to duplicate.
Motivation and Context
When an event shape is shared between multiple eventstreams, it causes SDK generation/compilation failures. The top level shape POJO implements the event stream interface for each stream and the return type of the
sdkEventTypemethod conflicts.Modifications
This PR adds two things:
duplicateAndRenameSharedEvents)EventStreamSharedEventProcessor) which applies the customization and raises helpful error messages if shared events are detected.Testing
Added new unit tests to cover processor/config. Manual testing of internal service model that raised this issue.
Screenshots (if appropriate)
N/A
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License