Skip to content

Add script to automatically set up a new module#6118

Merged
zoewangg merged 4 commits intomasterfrom
zoewang/addSetUpNewModuleScript
May 26, 2025
Merged

Add script to automatically set up a new module#6118
zoewangg merged 4 commits intomasterfrom
zoewang/addSetUpNewModuleScript

Conversation

@zoewangg
Copy link
Copy Markdown
Contributor

Motivation and Context

Add script to automatically set up a new module based on the checklist.

@zoewangg zoewangg requested a review from a team as a code owner May 16, 2025 21:25
@zoewangg zoewangg added the changelog-not-required Indicate changelog entry is not required for a specific PR label May 16, 2025
Comment thread scripts/setup-new-module Outdated
Comment thread scripts/setup-new-module Outdated
Comment thread scripts/setup-new-module Outdated
Copy link
Copy Markdown
Contributor

@alextwoods alextwoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Python version is much easier to read (at least for me) :)

Comment thread scripts/setup-new-module
print(f"Using SDK version: {sdk_version}")

with open(pom_path, 'w') as f:
f.write(f'''<?xml version="1.0" encoding="UTF-8"?>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: put the start of text on new line for readability and consistency with other text below

@zoewangg zoewangg enabled auto-merge May 26, 2025 18:09
@sonarqubecloud
Copy link
Copy Markdown

@zoewangg zoewangg added this pull request to the merge queue May 26, 2025
Merged via the queue into master with commit d8a0929 May 26, 2025
26 checks passed
@zoewangg zoewangg deleted the zoewang/addSetUpNewModuleScript branch June 11, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-not-required Indicate changelog entry is not required for a specific PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants