Skip to content

Ignore unknown properties on endpoints in endpoint rules.#6139

Merged
alextwoods merged 5 commits intomasterfrom
alexwoo/allow-unknown-endpoint-properties
Jun 20, 2025
Merged

Ignore unknown properties on endpoints in endpoint rules.#6139
alextwoods merged 5 commits intomasterfrom
alexwoo/allow-unknown-endpoint-properties

Conversation

@alextwoods
Copy link
Copy Markdown
Contributor

Warn instead of raising an exception on unknown endpoint properties.

Motivation and Context

The Rules engine Endpoint Object Properties member is defined as an arbitrary Map<string, object> and to support forwards compatibility/extensibility and comply with the specification, we should not be failing when an unknown property is present in the rules.

Modifications

  • Change the exception to a logger warning when an unknown (at this point, anything other than authSchemes) property is encountered in an Endpoint object.

Testing

Added new test case with endpoint rules with unknown property.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.

License

  • I confirm that this pull request can be released under the Apache 2 license

@alextwoods alextwoods requested a review from a team as a code owner May 28, 2025 21:24
@alextwoods alextwoods requested a review from sugmanue May 28, 2025 21:24
@alextwoods alextwoods enabled auto-merge June 20, 2025 15:55
@sonarqubecloud
Copy link
Copy Markdown

@alextwoods alextwoods added this pull request to the merge queue Jun 20, 2025
Merged via the queue into master with commit b815c13 Jun 20, 2025
28 checks passed
@github-actions
Copy link
Copy Markdown

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 20, 2025
@alextwoods alextwoods deleted the alexwoo/allow-unknown-endpoint-properties branch August 15, 2025 19:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants