Fix connectionPoolingWorks test for Apache5.x by fixing setConnectionTimeToLive for Apache5.x

[joviegas]

Motivation and Context

Issue

After migrating from Apache HttpClient 4.x to 5.x, connectionPoolingWorks() connection pooling tests are failing with the assertion error:

java.lang.AssertionError: 
Expecting actual:
  5
to be less than or equal to:
  2

Expected Behavior: HTTP connections should be reused from the connection pool for subsequent requests, creating only 1-2 total connections for 5 requests.

Actual Behavior: Each request creates a new connection (5 total connections), indicating that connections are not being reused despite being properly returned to the pool.

Observed Symptoms:

• Pool correctly shows Available: 1, Leased: 0 between requests
• Connections are marked as "can be kept alive for 60000 MILLISECONDS"
• However, connections are immediately closed with "close connection GRACEFUL" when leased from pool
• New connections are created for each subsequent request

Root Cause Analysis

The Core Issue: Semantic Breaking Change

Through systematic debugging, we isolated the issue to the setConnectionTimeToLive() configuration in ApacheConnectionManagerFactory.create():

// Apache 4.x PoolEntry constructor logic
if (timeToLive > 0) {
    final long deadline = this.created + timeUnit.toMillis(timeToLive);
    this.validityDeadline = deadline > 0 ? deadline : Long.MAX_VALUE;
} else {
    // timeToLive <= 0 treated as INFINITE (never expires)
    this.validityDeadline = Long.MAX_VALUE;  
}

Apache 5.x Behavior:

    timeToLive = 0: Immediate expiration (connections expire instantly)
    timeToLive > 0: Normal expiration behavior

Modifications

• We set the setConnectionTimeToLive on Apache 5.x only if a non Zero value is set , since Apache 5.x defaults it to -1 which is Infinite value

Testing

• Junit added back with this PR , earlier it was commented.

License

• I confirm that this pull request can be released under the Apache 2 license

[sonarqubecloud]

Quality Gate failed

Failed conditions
65.9% Coverage on New Code (required ≥ 80%)
21.0% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[joviegas]

Note that SdkHttpConfigurationOption sets default value as 0 in

aws-sdk-java-v2/http-client-spi/src/main/java/software/amazon/awssdk/http/SdkHttpConfigurationOption.java

Line 145 in 86bb440

private static final Duration DEFAULT_CONNECTION_TIME_TO_LIVE = Duration.ZERO;

[davidh44]

Junit added back with this PR , earlier it was commented.

Is that this test? Its being removed not added back

[joviegas]

Since Apache5HttpClientWireMockTest extends SdkHttpClientTestSuite

Its been added back , since we removed the empty test from here it will pick up the actual test from

aws-sdk-java-v2/test/http-client-tests/src/main/java/software/amazon/awssdk/http/SdkHttpClientTestSuite.java

Lines 121 to 146 in 0af784d

	public void connectionPoolingWorks() throws Exception {
	int initialOpenedConnections = CONNECTION_COUNTER.openedConnections();
	SdkHttpClientOptions httpClientOptions = new SdkHttpClientOptions();
	httpClientOptions.trustAll(true);
	try (SdkHttpClient client = createSdkHttpClient(httpClientOptions)) {
	stubForMockRequest(200);
	for (int i = 0; i < 5; i++) {
	SdkHttpFullRequest req = mockSdkRequest("http://localhost:" + mockServer.port(), SdkHttpMethod.POST);
	HttpExecuteResponse response =
	client.prepareRequest(HttpExecuteRequest.builder()
	.request(req)
	.contentStreamProvider(req.contentStreamProvider().orElse(null))
	.build())
	.call();
	response.responseBody().ifPresent(IoUtils::drainInputStream);
	}
	// connection pool growth strategies vary across client implementations. Some, such as the CRT grow connection counts
	// by a factor of 2, while some grow strictly as requested. Mainly we want to test that it kicks in at some point and
	// doesn't create a new connection for all 5 requests. This proves that while allowing variance in this behavior.
	assertThat(CONNECTION_COUNTER.openedConnections()).isGreaterThanOrEqualTo(initialOpenedConnections + 1);
	assertThat(CONNECTION_COUNTER.openedConnections()).isLessThanOrEqualTo(initialOpenedConnections + 2);
	}
	}