Fix DDB Enhanced Client immutable class introspection fails for "is" prefix fields#6349
Merged
S-Saranya1 merged 2 commits intomasterfrom Aug 15, 2025
Merged
Conversation
…is prefix fields issue
dagnir
reviewed
Aug 14, 2025
...ced/src/test/java/software/amazon/awssdk/enhanced/dynamodb/ImmutableBooleanIsPrefixTest.java
Outdated
Show resolved
Hide resolved
|
dagnir
approved these changes
Aug 15, 2025
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fix DDB Enhanced Client immutable class introspection fails for "is" prefix fields. Fixes #4446.
Motivation and Context
TableSchema.fromImmutableClass() fails with IllegalArgumentException when processing immutable classes that have boolean fields using "is" prefix in both getters and setters (e.g., isRusty() getter and isRusty(boolean) setter).
Root Cause
The ImmutableIntrospector had getter, setter name normalization logic where getter normalization removes "is" prefix (isRusty() - "rusty") but setter normalization keeps "is" prefix (isRusty(boolean) - "isRusty"). This caused property matching to fail and cause this exception -
java.lang.IllegalArgumentException: A method was found on the immutable class that does not appear to have a matching setter on the builder class.Modifications
Modified
normalizeSetterName()method inImmutableIntrospectorto add logic for handling "is" prefix for boolean parameters with the same logic as innormalizeGetterName(). This ensures both getter and setter methods now normalize to the same property name, enabling proper matching during introspection.Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License