Merged
Conversation
…rs the entire content and sup… (#6313) * Add BufferingAsyncRequestBody that buffers the entire content and supports multiple concurrent subscribers * Apply suggestions from code review * Update existing byteBuffersAsyncRequestBody to support multicast
…uestBody that returns an SdkP… (#6346) * Introduce a new split method in AsyncRequestBody that returns an SdkPublisher of ClosableAsyncRequestBody and use it in s3 multipart client * Fix build and add more tests * Refactoring based on API surface are review * Add more tests and address comments * Deprecate split, update documentation and add changelog entries
|
davidh44
approved these changes
Aug 28, 2025
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Motivation and Context
Currently retry is not supported for putObject operation in S3 multipart client if a non-file based AsyncRequestBody is configured. When a retry is attempted, the following error will be thrown. See
#6198
This pull request adds support retries for individual parts of a multipart upload in S3 multipart client through a new API:
BufferedSplittableAsyncRequestBodyCode Example:
Modifications
The changes have been reviewed previously in #6313 and #6346