Feature ID implementation - CREDENTIALS_IMDS#6380
Closed
S-Saranya1 wants to merge 3 commits intofeature/master/feature-ids-implementationfrom
Closed
Feature ID implementation - CREDENTIALS_IMDS#6380S-Saranya1 wants to merge 3 commits intofeature/master/feature-ids-implementationfrom
S-Saranya1 wants to merge 3 commits intofeature/master/feature-ids-implementationfrom
Conversation
L-Applin
suggested changes
Aug 29, 2025
| AwsCredentials credentials = executionAttributes.getAttribute(AwsSignerExecutionAttribute.AWS_CREDENTIALS); | ||
|
|
||
| if (credentials != null && isImdsCredentials(credentials)) { | ||
| executionAttributes.getAttribute(SdkInternalExecutionAttribute.BUSINESS_METRICS) |
Contributor
There was a problem hiding this comment.
is there any chances getAttribute could return null?
|
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CREDENTIALS_IMDS business metric feature implementation that tracks when Instance Metadata Service (IMDS) credentials are being used in AWS SDK requests.
Motivation and Context
Adding business metric for feature ID to track IMDS (Instance Metadata Service) credential usage in AWS SDK requests this track customer adoption of the feature.
Modifications
CREDENTIALS_IMDS("0")toBusinessMetricFeatureIdenumImdsCredentialsBusinessMetricInterceptorthat detects IMDS credentials by checking ifproviderNamecontains "InstanceProfile"execution.interceptorsto run automatically on every SDK requestTesting
Added unit and integration tests
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License