Closed
Conversation
cc254ef to
8e68acd
Compare
alextwoods
reviewed
Aug 28, 2025
When generating the for the endpoint interceptor, don't assume that the endpoint params contains a 'region' member; endpoint rulesets are not required to have this parameter; in situations where the endpoint params does not have this member, compilation fails. For backwards compatibility, give the region endpoint params preference if it exists; otherwise use the region from the execution attributes.
8e68acd to
f280f60
Compare
alextwoods
previously approved these changes
Aug 28, 2025
|
Contributor
Author
|
Realized there's a forwards compatibility issue if a service adds a |
Contributor
Author
|
Closing this PR for now. Will revive once we settle on the solution as a team. |
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Motivation and Context
When generating the for the endpoint interceptor, don't assume that the
endpoint params contains a 'region' member; endpoint rulesets are not
required to have this parameter; in situations where the endpoint params
does not have this member, compilation fails.
For backwards compatibility, give the region endpoint params preference
if it exists; otherwise use the region from the execution attributes.
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License