Skip to content

Preserve content-length when calling mark in SdkLengthAwareInputStream#6408

Merged
alextwoods merged 4 commits intomasterfrom
alexwoo/fix_length_aware_mark
Sep 15, 2025
Merged

Preserve content-length when calling mark in SdkLengthAwareInputStream#6408
alextwoods merged 4 commits intomasterfrom
alexwoo/fix_length_aware_mark

Conversation

@alextwoods
Copy link
Copy Markdown
Contributor

@alextwoods alextwoods commented Sep 8, 2025

Preserve content-length when calling mark in SdkLengthAwareInputStream

Motivation and Context

This does not change when exceptions are raised - it only changes the text in the exception.

Prior to this change, when mark was called on a SdkLengthAwareInputStream, it would reset the expected length to be the remaining bytes. If all of the bytes were not read from the stream the exception would have the message: The request content has fewer bytes than the specified content-length: <length based on remaining bytes when mark was called>. With this change, the specified content-length in the exception will be the originally provided length.

Modifications

  • Makes length final on construction and adds a new markedRemaining to store the number of remaining bytes.

Testing

New and existing tests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@alextwoods alextwoods marked this pull request as ready for review September 15, 2025 17:48
@alextwoods alextwoods requested a review from a team as a code owner September 15, 2025 17:48
@sonarqubecloud
Copy link
Copy Markdown

@alextwoods alextwoods added this pull request to the merge queue Sep 15, 2025
Merged via the queue into master with commit eb3f3e6 Sep 15, 2025
47 of 48 checks passed
@github-actions
Copy link
Copy Markdown

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants