Skip to content

Flaky test fix for StoringSubscriberTest#6420

Merged
Fred1155 merged 2 commits intomasterfrom
bole/storingsubscriber-flakytest-fix
Sep 15, 2025
Merged

Flaky test fix for StoringSubscriberTest#6420
Fred1155 merged 2 commits intomasterfrom
bole/storingsubscriber-flakytest-fix

Conversation

@Fred1155
Copy link
Copy Markdown
Contributor

Motivation and Context

The stochastic_subscriberSeemsThreadSafe test in StoringSubscriberTest is flaky and gives

[ERROR]   StoringSubscriberTest.stochastic_subscriberSeemsThreadSafe:188 » Execution org.opentest4j.AssertionFailedError: 
expected: 0
 but was: 1

The reason seems to be that the onSubscribe() likely triggers an initial request(n) call, the Producer immediately starts sending messages (0, 1, 2...). However, consumer thread starts later and may miss message 0 .

Modifications

Start consumer first and then call the onSubscribe()

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@Fred1155 Fred1155 requested a review from a team as a code owner September 15, 2025 20:22
@Fred1155 Fred1155 added the changelog-not-required Indicate changelog entry is not required for a specific PR label Sep 15, 2025
@sonarqubecloud
Copy link
Copy Markdown

@Fred1155 Fred1155 added this pull request to the merge queue Sep 15, 2025
Merged via the queue into master with commit cac2b30 Sep 15, 2025
41 checks passed
@github-actions
Copy link
Copy Markdown

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2025
@Fred1155 Fred1155 deleted the bole/storingsubscriber-flakytest-fix branch September 16, 2025 16:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

changelog-not-required Indicate changelog entry is not required for a specific PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants