Skip to content

Add business metric support for S3 Express Bucket#6517

Merged
S-Saranya1 merged 8 commits into
masterfrom
somepal/s3-express-featureID-implementation
Oct 28, 2025
Merged

Add business metric support for S3 Express Bucket#6517
S-Saranya1 merged 8 commits into
masterfrom
somepal/s3-express-featureID-implementation

Conversation

@S-Saranya1

@S-Saranya1 S-Saranya1 commented Oct 24, 2025

Copy link
Copy Markdown
Contributor

S3_EXPRESS_BUCKET business metric feature implementation that tracks when an operation called using the S3 Express feature.

Motivation and Context

Adding business metrics for feature IDs to track S3 Express (feature ID "J") usage in AWS SDK S3 requests. This tracks customer adoption of these S3 feature.

When the bucket name matches S3 Express Ruleset and express credentials are used, the SDK SHOULD track a business metric.

Modifications

  • Added S3ExpressUtils.addS3ExpressBusinessMetricIfApplicable() utility method that adds S3_EXPRESS_BUCKET business metric (feature ID "J") when both S3 Express endpoint resolution and S3 Express auth scheme are used.

  • Modified EndpointResolverInterceptorSpec code generation to call the S3 Express business metrics method during endpoint resolution for S3 service

Testing

  • Added functional tests to verify User-Agent header contains correct business metric when S3ExpressBucket is used.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@S-Saranya1 S-Saranya1 requested a review from a team as a code owner October 24, 2025 18:41
@S-Saranya1 S-Saranya1 changed the title Somepal/s3 express feature id implementation S3 express feature id implementation Oct 24, 2025
@S-Saranya1 S-Saranya1 changed the title S3 express feature id implementation S3Express feature id implementation Oct 24, 2025
@S-Saranya1 S-Saranya1 changed the title S3Express feature id implementation Add business metric support for S3 Express Bucket Oct 24, 2025
@S-Saranya1 S-Saranya1 added the no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required label Oct 27, 2025
@S-Saranya1 S-Saranya1 added this pull request to the merge queue Oct 27, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 27, 2025
@S-Saranya1 S-Saranya1 enabled auto-merge October 27, 2025 22:31
@S-Saranya1 S-Saranya1 added this pull request to the merge queue Oct 27, 2025
auto-merge was automatically disabled October 27, 2025 23:50

Pull Request is not mergeable

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
10.8% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Merged via the queue into master with commit 88c04bd Oct 28, 2025
46 of 50 checks passed
@github-actions

Copy link
Copy Markdown

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 28, 2025
@S-Saranya1 S-Saranya1 deleted the somepal/s3-express-featureID-implementation branch October 28, 2025 23:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants