Integ testing with Apache 5#6611
Conversation
This commit creates a new buildspecs/apache5-integ-test.yml that applies a patch that updates the SDK and integ tests to use the Apache 5.x client before running the integ tests.
dagnir
force-pushed
the
dongie/apache5-integ-testing
branch
from
a82b42d to
cf30038
Compare
|
Integ tests succeed with Apache 5 (see #6610). This PR is to so integ tests run with Apache 5 in parallel for PRs |
|
| AWS_SESSION_TOKEN=`echo $ASSUME_ROLE_OUTPUT | awk '{ print $3 }'` | ||
| echo "Using role $INTEGRATION_TEST_ROLE_ARN with access key $AWS_ACCESS_KEY_ID." | ||
| fi | ||
| - git apply buildspecs/apache5-integ-test/0001-Replace-Apache-4.x-with-5.x.patch |
There was a problem hiding this comment.
Question: Is there any chance that patch fails to apply due to line shifts or modifications in those target files? For example, if someone submits a PR that refactors imports or modifies HTTP client usage in CloudFrontUtilitiesIntegrationTest.java, would git apply fail and continue running tests with Apache 4 code instead of Apache 5?
There was a problem hiding this comment.
Do we need error handling here to prevent silent failures where the patch doesn't apply but tests continue with Apache 4, creating a false positive?
There was a problem hiding this comment.
Yes there is a chance. If the git apply fails here, the CodeBuild job will exit with an error. The commands are not concatenated with a pipe (|)
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
3 participants
Motivation and Context
This commit creates a new buildspecs/apache5-integ-test.yml that applies a patch that updates the SDK and integ tests to use the Apache 5.x client before running the integ tests.
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License