Skip to content

Make apache5-client the default sync HTTP client#6732

Open
dagnir wants to merge 7 commits into
masterfrom
dongie/apache5-as-default
Open

Make apache5-client the default sync HTTP client#6732
dagnir wants to merge 7 commits into
masterfrom
dongie/apache5-as-default

Conversation

@dagnir
Copy link
Copy Markdown
Contributor

@dagnir dagnir commented Feb 12, 2026 •
edited
Loading

Motivation and Context

This commit swaps the default apache-client dependency of service modules with apache5-client. Applications just relying on the default HTTP client will now use Apache5HttpClient as a result.

Modifications

  • Replace apache-client with apache5-client
  • Update tests that use ApacheHttpClient directly
  • Bump minor version to 2.42.0-SNAPSHOT

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir dagnir changed the title Dongie/apache5 as default Make apache5-client the default HTTP client Feb 12, 2026
@dagnir dagnir changed the title Make apache5-client the default HTTP client Make apache5-client the default sync HTTP client Feb 12, 2026
@dagnir dagnir force-pushed the dongie/apache5-as-default branch from 3ac9407 to 7d111aa Compare February 12, 2026 00:31
@dagnir dagnir force-pushed the dongie/apache5-as-default branch from 7d111aa to 501ee26 Compare February 24, 2026 00:01
dagnir
dagnir commented Feb 24, 2026
View reviewed changes
Comment thread .changes/next-release/feature-AWSSDKforJavav2-890d71f.json Outdated
"type": "feature",
"category": "AWS SDK for Java v2",
"contributor": "",
"description": "This update replaces the default `apache-client` runtime dependency of service clients with the new `apache5-client`. This means that service clients will now use the `Apache5HttClient` by default if no HTTP client is explicitly configured on the service client builder. The SDK version is also updates to `2.42.0` to reflect this change in default client."
Copy link
Copy Markdown
Contributor Author

@dagnir dagnir Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: version will be bumped before merging since releases done before then will cause merge conflicts.

@dagnir dagnir marked this pull request as ready for review February 24, 2026 00:09
@dagnir dagnir requested a review from a team as a code owner February 24, 2026 00:09
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 24, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
50.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@dagnir dagnir mentioned this pull request Mar 18, 2026
Merged
12 tasks
@debora-ito debora-ito mentioned this pull request Apr 21, 2026
Open
2 tasks
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 22, 2026

Quality Gate Passed Quality Gate passed

Issues
30 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@debora-ito debora-ito mentioned this pull request Apr 29, 2026
Open
2 tasks
@patrickjamesbarry
Copy link
Copy Markdown

patrickjamesbarry commented May 13, 2026

Been waiting a long time on this. Are we any closer to merging this change?

@joviegas joviegas enabled auto-merge May 15, 2026 23:06
@joviegas joviegas force-pushed the dongie/apache5-as-default branch from 5c1544e to a807c94 Compare May 15, 2026 23:17
@joviegas joviegas disabled auto-merge May 15, 2026 23:17
dagnir and others added 6 commits May 15, 2026 16:30
@dagnir @joviegas
Swap apache-client with apache5-client
b27193c 
This commit swaps the default apache-client dependency of service
modules with apache5-client. Applications just relying on the default
HTTP client will now use `Apache5HttpClient` as a result.
@dagnir @joviegas
Fix CloudFrontUtilitiesIntegrationTest
5b95ceb
@dagnir @joviegas
Fix S3 tests
496694c
@dagnir @joviegas
Update version in changelog entry
5bfeb15
@dagnir @joviegas
Revert to 4.x for test
344769f 
Expect100ContinueHeaderTest tests 4.x specific behavior (default
100-continue).
@joviegas
Add apache-client to aws-sdk-java module to prevent NoClassDefFoundEr…
6cd3046 
…ror for customers using ApacheHttpClient in environments that bundle the whole SDK (e.g., EMR) after apache5-client default switch (#6964)
@joviegas joviegas force-pushed the dongie/apache5-as-default branch 2 times, most recently from 83ddb4a to 6cd3046 Compare May 17, 2026 00:02
@joviegas
fix(integ-test): Fix Integ test issue after making Apache5 as default (…
e4412be 
…#6974)

* fix(dynamodb): Add TCP keep-alive permissions to SecurityManager test policy for Apache 5 compatibility. Apache 5.6 sets TCP_KEEPIDLE/INTERVAL/COUNT by default which requires jdk.net.NetworkPermission.

* Fix ResponseInputStreamTimeoutIntegrationTest to update it to Apache5 exception assertion

* Remove apache5-client test scope from s3/pom.xml to restore runtime transitivity. The test scope override prevented downstream modules like s3-transfer-manager from discovering the HTTP client via SPI

* Dumy commit to trigger integ test

* because we use  org.apache.hc.core5.http.ConnectionRequestTimeoutException in ResponseInputStreamTimeoutIntegrationTest

* Removing Apache5 specific execption from ResponseInputStreamTimeoutIntegrationTest and asserting just on error message

* remove apache 5 as test dependency since it present as runtime
@chris-mcc
Copy link
Copy Markdown

chris-mcc commented May 24, 2026

I was wondering if there should be a default 3rd party http client impl

In my head it being explicit might help down stream compatibility.

Take the example of https://github.com/awspring/spring-cloud-aws

They have releases to spring boot so 4.0 is using 5.5 4.1 is 5.6

Also if there's a hard dependency on apache http 5

spring boot 4 etc might automatically configure using the apache libs, changing app behaviour

My current thinking is that:
having a fallback java 11 http client, with downstream projects explicitly configure the sdk might be better longer term

In saying that the benefit of using apache http5 client by default is that is very performant out of the box; especially if on Java 25 using virtual threads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fred1155 Fred1155 Fred1155 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dagnir @patrickjamesbarry @chris-mcc @Fred1155 @joviegas