Skip to content

SnsMessageManager Impl #6804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dagnir merged 4 commits into from
Mar 30, 2026

Fix test

d2ed893
Select commit
Loading
Failed to load commit list.
Refresh
Merged

SnsMessageManager Impl #6804

Fix test
d2ed893
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 28, 2026 in 16m 18s

Quality Gate failed

Failed conditions
1 Security Hotspot
46.3% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 772 in services/sns/src/test/java/software/amazon/awssdk/services/sns/internal/messagemanager/CertificateRetrieverTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Thread.sleep()". 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0x0gI4PeizfJ0Xm0qo&open=AZ0x0gI4PeizfJ0Xm0qo&pullRequest=6804

Check warning on line 109 in services-custom/sns-message-manager/src/test/java/software/amazon/awssdk/messagemanager/sns/internal/SignatureValidatorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0x0gSWPeizfJ0Xm0ra&open=AZ0x0gSWPeizfJ0Xm0ra&pullRequest=6804

Check failure on line 48 in services/sns/src/main/java/software/amazon/awssdk/services/sns/internal/messagemanager/SnsMessageParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "TopicArn" 4 times. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0x0gK-PeizfJ0Xm0q_&open=AZ0x0gK-PeizfJ0Xm0q_&pullRequest=6804

Check warning on line 134 in services-custom/sns-message-manager/src/test/java/software/amazon/awssdk/messagemanager/sns/internal/SignatureValidatorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.security.cert.CertificateException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0x0gSWPeizfJ0Xm0rc&open=AZ0x0gSWPeizfJ0Xm0rc&pullRequest=6804

Check warning on line 93 in services/sns/src/main/java/software/amazon/awssdk/services/sns/internal/messagemanager/CertificateRetriever.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "DEFAULT_HTTP_TIMEOUT" private field. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0x0gKnPeizfJ0Xm0q7&open=AZ0x0gKnPeizfJ0Xm0q7&pullRequest=6804

Check warning on line 560 in services/sns/src/test/java/software/amazon/awssdk/services/sns/internal/messagemanager/CertificateRetrieverTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Join these multiple assertions subject to one assertion chain. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0x0gI4PeizfJ0Xm0qj&open=AZ0x0gI4PeizfJ0Xm0qj&pullRequest=6804

Check warning on line 375 in services/sns/src/test/java/software/amazon/awssdk/services/sns/messagemanager/SnsMessageManagerIntegrationTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Join these multiple assertions subject to one assertion chain. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0x0gJlPeizfJ0Xm0qy&open=AZ0x0gJlPeizfJ0Xm0qy&pullRequest=6804

Check warning on line 235 in services/sns/src/test/java/software/amazon/awssdk/services/sns/messagemanager/SnsMessageManagerIntegrationTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0x0gJlPeizfJ0Xm0qx&open=AZ0x0gJlPeizfJ0Xm0qx&pullRequest=6804

Check warning on line 201 in services-custom/sns-message-manager/src/test/java/software/amazon/awssdk/messagemanager/sns/internal/SnsMessageUnmarshallerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0x0gR9PeizfJ0Xm0rW&open=AZ0x0gR9PeizfJ0Xm0rW&pullRequest=6804

Check warning on line 157 in services/sns/src/test/java/software/amazon/awssdk/services/sns/internal/messagemanager/CertificateRetrieverTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0x0gI4PeizfJ0Xm0qi&open=AZ0x0gI4PeizfJ0Xm0qi&pullRequest=6804

Check warning on line 245 in services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/multipart/UploadWithUnknownContentLengthHelper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Call "Optional#isPresent()" before accessing the value. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0x0gGLPeizfJ0Xm0qX&open=AZ0x0gGLPeizfJ0Xm0qX&pullRequest=6804

Check warning on line 39 in services-custom/sns-message-manager/src/test/java/software/amazon/awssdk/messagemanager/sns/internal/DefaultSnsMessageManagerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0x0gSmPeizfJ0Xm0rf&open=AZ0x0gSmPeizfJ0Xm0rf&pullRequest=6804

Check warning on line 73 in services/sns/src/test/java/software/amazon/awssdk/services/sns/internal/messagemanager/SignatureValidatorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0x0gIaPeizfJ0Xm0qh&open=AZ0x0gIaPeizfJ0Xm0qh&pullRequest=6804

Check warning on line 70 in services/sns/src/main/java/software/amazon/awssdk/services/sns/internal/messagemanager/SnsMessageParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "Arrays.copyOf", "Arrays.asList", "Collections.addAll" or "System.arraycopy" instead. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0x0gK-PeizfJ0Xm0rI&open=AZ0x0gK-PeizfJ0Xm0rI&pullRequest=6804

Check warning on line 189 in services-custom/sns-message-manager/src/test/java/software/amazon/awssdk/messagemanager/sns/internal/SnsMessageUnmarshallerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0x0gR9PeizfJ0Xm0rV&open=AZ0x0gR9PeizfJ0Xm0rV&pullRequest=6804

Check warning on line 33 in services/sns/src/test/java/software/amazon/awssdk/services/sns/internal/messagemanager/CertificateRetrieverTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'java.util.concurrent.CompletableFuture'. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0x0gI4PeizfJ0Xm0qq&open=AZ0x0gI4PeizfJ0Xm0qq&pullRequest=6804

Check warning on line 702 in services/sns/src/test/java/software/amazon/awssdk/services/sns/internal/messagemanager/CertificateRetrieverTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use isZero() instead. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0x0gI4PeizfJ0Xm0qn&open=AZ0x0gI4PeizfJ0Xm0qn&pullRequest=6804

Check failure on line 48 in services/sns/src/main/java/software/amazon/awssdk/services/sns/internal/messagemanager/SnsMessageParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "MessageId" 4 times. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0x0gK-PeizfJ0Xm0rH&open=AZ0x0gK-PeizfJ0Xm0rH&pullRequest=6804

Check warning on line 166 in services/sns/src/main/java/software/amazon/awssdk/services/sns/messagemanager/MessageManagerConfiguration.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add the "@Override" annotation above this method signature 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0x0gLZPeizfJ0Xm0rK&open=AZ0x0gLZPeizfJ0Xm0rK&pullRequest=6804

Check warning on line 29 in services/sns/src/test/java/software/amazon/awssdk/services/sns/internal/messagemanager/CertificateRetrieverTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'java.io.InputStream'. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0x0gI4PeizfJ0Xm0qp&open=AZ0x0gI4PeizfJ0Xm0qp&pullRequest=6804

Check warning on line 390 in services/sns/src/test/java/software/amazon/awssdk/services/sns/messagemanager/SnsMessageManagerIntegrationTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Join these multiple assertions subject to one assertion chain. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0x0gJlPeizfJ0Xm0q0&open=AZ0x0gJlPeizfJ0Xm0q0&pullRequest=6804

Check warning on line 29 in services-custom/sns-message-manager/src/test/java/software/amazon/awssdk/messagemanager/sns/internal/UnmanagedSdkHttpClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0x0gRpPeizfJ0Xm0rQ&open=AZ0x0gRpPeizfJ0Xm0rQ&pullRequest=6804

Check warning on line 35 in test/architecture-tests/src/test/java/software/amazon/awssdk/archtests/PackageContainmentTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'software.amazon.awssdk.core.internal.http.loader.DefaultSdkHttpClientBuilder'. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0x0gPbPeizfJ0Xm0rM&open=AZ0x0gPbPeizfJ0Xm0rM&pullRequest=6804

Check failure on line 48 in services/sns/src/main/java/software/amazon/awssdk/services/sns/internal/messagemanager/SnsMessageParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "SignatureVersion" 4 times. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0x0gK-PeizfJ0Xm0rF&open=AZ0x0gK-PeizfJ0Xm0rF&pullRequest=6804

Check warning on line 21 in services-custom/sns-message-manager/src/test/java/software/amazon/awssdk/messagemanager/sns/model/SnsNotificationTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0x0gRbPeizfJ0Xm0rP&open=AZ0x0gRbPeizfJ0Xm0rP&pullRequest=6804
View more details on SonarQubeCloud