Add a workaround for connection acquire issue#6808
Merged
Conversation
There appears to be an issue in rare circumstances where a connection acquire fails so that no connection is leased from the pool, and validation of the connection subsequently fails, causing the underlying HTTP client to throw. This adds a workaround for this issue by rethrowing the exception wrapped in an IOException to at least give the upper layer an opportunity to retry the request.
RanVaknin
requested changes
Mar 25, 2026
...ents/apache5-client/src/main/java/software/amazon/awssdk/http/apache5/Apache5HttpClient.java
Show resolved
Hide resolved
RanVaknin
approved these changes
Mar 25, 2026
dagnir
added
the
no-api-surface-area-change
|
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There appears to be an issue in rare circumstances where a connection acquire fails so that no connection is leased from the pool, and validation of the connection subsequently fails, causing the underlying HTTP client to throw.
This adds a workaround for this issue by rethrowing the exception wrapped in an IOException to at least give the upper layer an opportunity to retry the request.
Motivation and Context
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License