Skip to content

Ensure token cache files are created with 0600#6867

Merged
alextwoods merged 4 commits intomasterfrom
alexwoo/login_cache_permissions
Apr 16, 2026
Merged

Ensure token cache files are created with 0600#6867
alextwoods merged 4 commits intomasterfrom
alexwoo/login_cache_permissions

Conversation

@alextwoods
Copy link
Copy Markdown
Contributor

@alextwoods alextwoods commented Apr 16, 2026

Motivation and Context

Add defensive checks to ensure token cache file for login and sso-oidc is written with user read permissions only where possible. Also uses the atomic write/move pattern in sso-oidc to avoid potential read race conditions.

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@alextwoods alextwoods marked this pull request as ready for review April 16, 2026 17:43
@alextwoods alextwoods requested a review from a team as a code owner April 16, 2026 17:43
@alextwoods alextwoods enabled auto-merge April 16, 2026 18:01
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
66.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@alextwoods alextwoods added this pull request to the merge queue Apr 16, 2026
Merged via the queue into master with commit 7779d25 Apr 16, 2026
39 of 41 checks passed
@github-actions
Copy link
Copy Markdown

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2026
@alextwoods alextwoods deleted the alexwoo/login_cache_permissions branch April 16, 2026 20:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants