Factor new retries option in client builder#6887
Merged
dagnir merged 3 commits intofeature/master/2026-new-retriesfrom Apr 23, 2026
Merged
Factor new retries option in client builder#6887dagnir merged 3 commits intofeature/master/2026-new-retriesfrom
dagnir merged 3 commits intofeature/master/2026-new-retriesfrom
Conversation
dagnir
force-pushed
the
dongie/2026-new-retries-internal-default
branch
4 times, most recently
from
3572070 to
d189e00
Compare
This commit updates the retry mode resolution behavior for SDK clients: - When resolving the RetryStrategy to use, also determine whether retry 2.1 behavior should be enabled for that retry strategy. - If the `newRetries2026Default` property is set in customization.config for a service, ensure that this is treated as the default option for `AWS_NEW_RETRIES_2026` when building the client if not set anywhere else.
dagnir
force-pushed
the
dongie/2026-new-retries-internal-default
branch
from
d189e00 to
cd95577
Compare
Fred1155
reviewed
Apr 22, 2026
| new TestData("lEgAcY", null, null, null, RetryMode.LEGACY), | ||
| new TestData("sTanDaRd", null, null, null, RetryMode.STANDARD), | ||
| new TestData("aDaPtIvE", null, null, null, RetryMode.ADAPTIVE_V2), | ||
| new TestData("legacy", null, null, null, null, null, null, RetryMode.LEGACY), |
Contributor
There was a problem hiding this comment.
Nit: seems there are some test appeared repeatedly?
Contributor
There was a problem hiding this comment.
line 74 to 79 is identical to 68 to 73?
Contributor
Author
There was a problem hiding this comment.
Ah yeah you're right. Will remove!
Contributor
Author
There was a problem hiding this comment.
nm, realized the intention for 68-73 was for 'false'. Updated.
Fred1155
approved these changes
Apr 23, 2026
| new TestData("lEgAcY", null, null, null, RetryMode.LEGACY), | ||
| new TestData("sTanDaRd", null, null, null, RetryMode.STANDARD), | ||
| new TestData("aDaPtIvE", null, null, null, RetryMode.ADAPTIVE_V2), | ||
| new TestData("legacy", null, null, null, null, null, null, RetryMode.LEGACY), |
Contributor
There was a problem hiding this comment.
line 74 to 79 is identical to 68 to 73?
|
dagnir
merged commit e528aa4
into
feature/master/2026-new-retries
12 of 14 checks passed
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This commit updates the retry mode resolution behavior for SDK clients:
2.1 behavior should be enabled for that retry strategy.
newRetries2026Defaultproperty is set incustomization.config for a service, ensure that this is treated as
the default option for
AWS_NEW_RETRIES_2026when building theclient if not set anywhere else.
Modifications
SdkClientOption.NEW_RETRIES_2026_DEFAULTinmergeInternalDefaults()if set on thecustomization.configRetryMode.Resolverto reference theAWS_NEW_RETRIES_2026config when resolving the appropriateRetryModeRetryStrategybased onRetryMode, also determine whether 2.1 behavior should be enabled.Testing
NewRetries2026ResolverRetryMode.Resolverunit testingScreenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License