Skip to content

Factor new retries option in client builder #6887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dagnir merged 3 commits into from
Apr 23, 2026

Fix test

e35ac0d
Select commit
Loading
Failed to load commit list.
Merged

Factor new retries option in client builder #6887

Fix test
e35ac0d
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Apr 23, 2026 in 16m 1s

Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.3% Coverage on New Code
0.1% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 38 in core/aws-core/src/test/java/software/amazon/awssdk/awscore/client/builder/InternalDefaultsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ22n5KBczfuCFFt3uJf&open=AZ22n5KBczfuCFFt3uJf&pullRequest=6887

Check warning on line 54 in core/sdk-core/src/test/java/software/amazon/awssdk/core/retry/NewRetries2026ResolverTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the parentheses around the "env" parameter 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ22n5I5czfuCFFt3uJd&open=AZ22n5I5czfuCFFt3uJd&pullRequest=6887

Check warning on line 72 in core/sdk-core/src/test/java/software/amazon/awssdk/core/internal/async/InputStreamWithExecutorAsyncRequestBodyTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ22n5EMczfuCFFt3uJZ&open=AZ22n5EMczfuCFFt3uJZ&pullRequest=6887

Check warning on line 23 in core/retries/src/test/java/software/amazon/awssdk/retries/StandardRetryStrategyV21ConstantsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'software.amazon.awssdk.retries.api.BackoffStrategy'. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ22n5KrczfuCFFt3uJh&open=AZ22n5KrczfuCFFt3uJh&pullRequest=6887

Check warning on line 63 in core/sdk-core/src/test/java/software/amazon/awssdk/core/async/AsyncRequestBodyFromInputStreamConfigurationTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ22n5JFczfuCFFt3uJe&open=AZ22n5JFczfuCFFt3uJe&pullRequest=6887

Check failure on line 74 in core/sdk-core/src/test/java/software/amazon/awssdk/core/internal/async/InputStreamWithExecutorAsyncRequestBodyTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change this "try" to a try-with-resources. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ22n5EMczfuCFFt3uJb&open=AZ22n5EMczfuCFFt3uJb&pullRequest=6887

Check warning on line 64 in core/aws-core/src/test/java/software/amazon/awssdk/awscore/client/builder/InternalDefaultsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the parentheses around the "env" parameter 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ22n5KBczfuCFFt3uJg&open=AZ22n5KBczfuCFFt3uJg&pullRequest=6887

Check warning on line 79 in http-clients/aws-crt-client/src/main/java/software/amazon/awssdk/http/crt/internal/response/InputStreamAdaptingHttpStreamResponseHandler.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this lambda with method reference 'responseHandlerHelper::closeStream'. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ22n5L4czfuCFFt3uJi&open=AZ22n5L4czfuCFFt3uJi&pullRequest=6887

Check failure on line 38 in core/sdk-core/src/test/java/software/amazon/awssdk/core/internal/async/InputStreamWithExecutorAsyncRequestBodyTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change this "try" to a try-with-resources. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ22n5EMczfuCFFt3uJa&open=AZ22n5EMczfuCFFt3uJa&pullRequest=6887

Check warning on line 29 in core/sdk-core/src/test/java/software/amazon/awssdk/core/retry/NewRetries2026ResolverTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ22n5I5czfuCFFt3uJc&open=AZ22n5I5czfuCFFt3uJc&pullRequest=6887

Check warning on line 36 in core/sdk-core/src/test/java/software/amazon/awssdk/core/internal/async/InputStreamWithExecutorAsyncRequestBodyTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ22n5EMczfuCFFt3uJY&open=AZ22n5EMczfuCFFt3uJY&pullRequest=6887
View more details on SonarQubeCloud