Skip to content

Support MRAP buckets in S3 TransferManager#6916

Merged
alextwoods merged 2 commits intomasterfrom
alexwoo/tm_mrap
Apr 29, 2026
Merged

Support MRAP buckets in S3 TransferManager#6916
alextwoods merged 2 commits intomasterfrom
alexwoo/tm_mrap

Conversation

@alextwoods
Copy link
Copy Markdown
Contributor

@alextwoods alextwoods commented Apr 28, 2026

Support MRAP buckets in S3 TransferManager.

Motivation and Context

Fixes: #3984

S3 MRAP now supports all multi-part operations.

Modifications

  • Remove check for MRAP ARN.

Testing

New unit tests.
Removed skip for MRAP buckets in existing TM regression tests (so no new tests needed to be added - existing tests will now run on an MRAP bucket). Example log lines:

2026-04-28 13:40:38 [main] INFO  software.amazon.awssdk.services.s3.regression.upload.UploadTransferManagerRegressionTesting:43 - Running putObject with config: UploadConfig(bucketType=MRAP, forcePathStyle=false, requestChecksumValidation=WHEN_SUPPORTED, bodyType=BUFFERED_SPLITTABLE_UNKNOWN_CONTENT_LENGTH, contentSize=LARGE, payloadSigning=false)

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.

License

  • I confirm that this pull request can be released under the Apache 2 license

@alextwoods alextwoods requested a review from a team as a code owner April 28, 2026 19:08
@@ -49,7 +48,6 @@ public static List<UploadConfig> testConfigs() {
void putObject(UploadConfig config) throws Exception {

assumeNotAccessPointWithPathStyle(config);
assumeNotMRAP(config);
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this enables running all of the tests on MRAP buckets as well.

@Fred1155
Copy link
Copy Markdown
Contributor

Do we need to run a one off test for CRT path?

@alextwoods alextwoods added this pull request to the merge queue Apr 29, 2026
@alextwoods
Copy link
Copy Markdown
Contributor Author

Do we need to run a one off test for CRT path?
Yeah, I did run one-off tests for the upload TM regression tests using the CRT client instead. This path is implicitly tested already through the UploadCrtRegressionTesting and I wanted to avoid adding new, slow tests so I didn't add new tests.

Merged via the queue into master with commit e219660 Apr 29, 2026
11 of 12 checks passed
@github-actions
Copy link
Copy Markdown

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 29, 2026
@alextwoods alextwoods deleted the alexwoo/tm_mrap branch April 29, 2026 18:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

S3 Transfer Manager does not support Multi-Region Access Points

2 participants