Support MRAP buckets in S3 TransferManager#6916
Merged
alextwoods merged 2 commits intomasterfrom Apr 29, 2026
Merged
Conversation
alextwoods
commented
Apr 28, 2026
| @@ -49,7 +48,6 @@ public static List<UploadConfig> testConfigs() { | |||
| void putObject(UploadConfig config) throws Exception { | |||
|
|
|||
| assumeNotAccessPointWithPathStyle(config); | |||
| assumeNotMRAP(config); | |||
Contributor
Author
There was a problem hiding this comment.
Removing this enables running all of the tests on MRAP buckets as well.
Fred1155
approved these changes
Apr 28, 2026
Contributor
|
Do we need to run a one off test for CRT path? |
Contributor
Author
|
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support MRAP buckets in S3 TransferManager.
Motivation and Context
Fixes: #3984
S3 MRAP now supports all multi-part operations.
Modifications
Testing
New unit tests.
Removed skip for MRAP buckets in existing TM regression tests (so no new tests needed to be added - existing tests will now run on an MRAP bucket). Example log lines:
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License