Skip to content

Propagate error to active chunk subscriber in SplittingPublisher#6982

Merged
davidh44 merged 1 commit into
masterfrom
hdavidh/propagate-error-to-current-subscriber
May 21, 2026
Merged

Propagate error to active chunk subscriber in SplittingPublisher#6982
davidh44 merged 1 commit into
masterfrom
hdavidh/propagate-error-to-current-subscriber

Conversation

@davidh44
Copy link
Copy Markdown
Contributor

@davidh44 davidh44 commented May 20, 2026

Motivation and Context

Fixed bug where SplittingPublisher.onError() did not signal the active SubAsyncRequestBody, causing its subscriber to hang until timeout instead of being notified immediately

Modifications

  • Call currentBody.error(t) in SplittingSubscriber.onError()
  • Add error(Throwable) to SubAsyncRequestBody interface
    • Implement error() in RetryableSubAsyncRequestBody
    • Override error() in NonRetryableSubAsyncRequestBody

Testing

Added unit test

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@davidh44 davidh44 requested a review from a team as a code owner May 20, 2026 00:00
@davidh44 davidh44 added this pull request to the merge queue May 20, 2026
Merged via the queue into master with commit 4fd3e0e May 21, 2026
14 checks passed
@github-actions
Copy link
Copy Markdown

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 21, 2026
@davidh44 davidh44 deleted the hdavidh/propagate-error-to-current-subscriber branch May 21, 2026 15:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants