chore: set legacy max attempts for DynamoDB

Author: yenfryherrerafeliz

src/DynamoDb/DynamoDbClient.php

@@ -7,6 +7,7 @@
 use Aws\Exception\AwsException;
 use Aws\HandlerList;
 use Aws\Middleware;
+use Aws\Retry\Configuration;
 use Aws\Retry\ConfigurationProvider;
 use Aws\RetryMiddleware;
 use Aws\RetryMiddlewareV2;
@@ -133,8 +134,9 @@
 class DynamoDbClient extends AwsClient
 {
     /** @internal */
-    const DYNAMODB_MAX_ATTEMPTS = 4;
-    const DEFAULT_BASE_DELAY_MS = 25;
+    private const DYNAMODB_MAX_ATTEMPTS = 4;
+    private const DEFAULT_BASE_DELAY_MS = 25;
+    public const DEFAULT_LEGACY_MAX_ATTEMPTS = 10;
 
     public static function getArguments(): array
     {
@@ -186,10 +188,17 @@ public static function _applyRetryConfig(mixed $value, array &$args, HandlerList
             $config = ConfigurationProvider::unwrap($value);
 
             if ($config->getMode() === 'legacy') {
+                $effectiveMaxAttempts = $config->getMaxAttempts() - 1;
+                // If the customer provided config is array and not max attempts
+                // were specified then we set the default of self::DEFAULT_LEGACY_MAX_ATTEMPTS
+                if (is_array($value) && !isset($value['max_attempts'])) {
+                    $effectiveMaxAttempts = self::DEFAULT_LEGACY_MAX_ATTEMPTS;
+                }
+
                 $list->appendSign(
                     Middleware::retry(
                         RetryMiddleware::createDefaultDecider(
-                            $config->getMaxAttempts() - 1,
+                            $effectiveMaxAttempts,
                             ['error_codes' => ['TransactionInProgressException']]
                         ),
                         function ($retries) {

tests/DynamoDb/DynamoDbClientTest.php

@@ -211,4 +211,33 @@ public function testAppliesRetryStatsConfig($settings)
             $this->assertGreaterThan(0, $e->getTransferInfo('retries_attempted'));
         }
     }
+
+    public function testSetLegacyMaxRetries()
+    {
+        $client = new DynamoDbClient([
+            'stats' => ['retries' => true],
+            'version' => 'latest',
+            'region' => 'us-west-2',
+            'handler' => function () {
+                return new RejectedPromise(
+                    new DynamoDbException('a', new Command('b'), [
+                        'connection_error' => true,
+                    ])
+                );
+            },
+            'retries' => [
+                'mode' => 'legacy'
+            ]
+        ]);
+        try {
+            $client->listTables();
+            $this->fail('The operation should have failed');
+        } catch (DynamoDbException $e) {
+            $this->assertNotNull($e->getTransferInfo('retries_attempted'));
+            $this->assertEquals(
+                DynamoDbClient::DEFAULT_LEGACY_MAX_ATTEMPTS,
+                $e->getTransferInfo('retries_attempted')
+            );
+        }
+    }
 }

tests/RetryMiddlewareV2Test.php

@@ -448,7 +448,7 @@ function (?string $retryAfter = null) use ($command) {
                     ],
                 ],
             ],
-            'Long-Polling backoff when token bucket empty' => [
+            'Long-Polling backoff when after transient error and token bucket empty' => [
                 'command' => new Command('ReceiveMessage'),
                 'queue' => [
                     $awsException500