chore: bulk tests fix

Author: yenfryherrerafeliz

tests/AbstractConfigurationProviderTest.php

@@ -2,6 +2,7 @@
 
 namespace Aws\Test;
 
+use Aws\AbstractConfigurationProvider;
 use Aws\LruArrayCache;
 use Aws\Result;
 use Aws\ResultInterface;
@@ -10,7 +11,7 @@
 use Yoast\PHPUnitPolyfills\TestCases\TestCase;
 use PHPUnit\Framework\Attributes\CoversClass;
 
-#[CoversClass(\Aws\AbstractConfigurationProvider::class)]
+#[CoversClass(AbstractConfigurationProvider::class)]
 class AbstractConfigurationProviderTest extends TestCase
 {
     /** @var MockObject */

tests/Api/ApiProviderTest.php

@@ -24,9 +24,9 @@ private function getTestApiProvider($useManifest = true)
 
     public function testCanResolveProvider()
     {
-        $p = function ($a, $b, $c) {return [];
-
-        $this->assertTrue(true);};
+        $p = function ($a, $b, $c) {
+            return [];
+        };
         $result = ['metadata'=> ['serviceIdentifier' => 's']];
         $this->assertEquals($result, ApiProvider::resolve($p, 't', 's', 'v'));
 

tests/Api/DateTimeResultTest.php

@@ -6,7 +6,7 @@
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\CoversClass;
 
-#[CoversClass(\Aws\Api\DateTimeResult::class)]
+#[CoversClass(DateTimeResult::class)]
 class DateTimeResultTest extends TestCase
 {
     public function testCreatesFromEpoch()
@@ -50,19 +50,14 @@ public function testJsonSerialzesAsIso8601()
         $this->assertSame('"' . gmdate('c', $t). '"', json_encode($d));
     }
 
-    /**
-     * @return void
-     *
-
- */
     #[DataProvider('nanosecondPrecisionProvider')]
     public function testIso8601NanosecondPrecision($timestamp, $expected)
     {
         $parsed = DateTimeResult::fromISO8601($timestamp);
         $this->assertEquals($expected, (string) $parsed);
     }
 
-    public static function nanosecondPrecisionProvider()
+    public static function nanosecondPrecisionProvider(): array
     {
         return [
             ['2024-07-31T19:05:47.1234567Z', '2024-07-31T19:05:47+00:00'],

tests/Api/ErrorParser/JsonRpcErrorParserTest.php

@@ -2,26 +2,19 @@
 namespace Aws\Test\Api\ErrorParser;
 
 use Aws\Api\ErrorParser\JsonRpcErrorParser;
+use Aws\Api\ErrorParser\JsonParserTrait;
 use Aws\Test\TestServiceTrait;
 use GuzzleHttp\Psr7;
 use PHPUnit\Framework\TestCase;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\CoversClass;
 
-#[CoversClass(\Aws\Api\ErrorParser\JsonRpcErrorParser::class)]
-#[CoversClass(\Aws\Api\ErrorParser\JsonParserTrait::class)]
+#[CoversClass(JsonRpcErrorParser::class)]
+#[CoversClass(JsonParserTrait::class)]
 class JsonRpcErrorParserTest extends TestCase
 {
     use TestServiceTrait;
 
-    /**
-     *
-     * @param string $response
-     * @param string|null $commandName
-     * @param bool $parserWithService
-     * @param array $expected
-
- */
     #[DataProvider('errorResponsesProvider')]
     public function testParsesClientErrorResponses(
         string $response,

tests/Api/ErrorParser/RestJsonErrorParserTest.php

@@ -2,26 +2,19 @@
 namespace Aws\Test\Api\ErrorParser;
 
 use Aws\Api\ErrorParser\RestJsonErrorParser;
+use Aws\Api\ErrorParser\JsonParserTrait;
 use Aws\Test\TestServiceTrait;
 use GuzzleHttp\Psr7;
 use PHPUnit\Framework\TestCase;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\CoversClass;
 
-#[CoversClass(\Aws\Api\ErrorParser\RestJsonErrorParser::class)]
-#[CoversClass(\Aws\Api\ErrorParser\JsonParserTrait::class)]
+#[CoversClass(RestJsonErrorParser::class)]
+#[CoversClass(JsonParserTrait::class)]
 class RestJsonErrorParserTest extends TestCase
 {
     use TestServiceTrait;
 
-    /**
-     *
-     * @param string $response
-     * @param string|null $commandName
-     * @param bool $parserWithService
-     * @param array $expected
-
- */
     #[DataProvider('errorResponsesProvider')]
     public function testParsesClientErrorResponses(
         string $response,

tests/Api/ErrorParser/XmlErrorParserTest.php

@@ -16,16 +16,14 @@ class XmlErrorParserTest extends TestCase
     use TestServiceTrait;
 
     /**
-     *
      * @param string $response
      * @param string $protocol
      * @param string $parser
      * @param array $expected
      * @param string|null $expectedParsedType
      *
      * @throws \Exception
-
- */
+     */
     #[DataProvider('errorResponsesProvider')]
     public function testParsesClientErrorResponses(
         string $response,

tests/Api/ListShapeTest.php

@@ -4,10 +4,10 @@
 use Aws\Api\Shape;
 use Aws\Api\ShapeMap;
 use Aws\Api\ListShape;
-use Yoast\PHPUnitPolyfills\TestCases\TestCase;
+use PHPUnit\Framework\TestCase;
 use PHPUnit\Framework\Attributes\CoversClass;
 
-#[CoversClass(\Aws\Api\ListShape::class)]
+#[CoversClass(ListShape::class)]
 class ListShapeTest extends TestCase
 {
     public function testReturnsMember()

tests/Api/MapShapeTest.php

@@ -4,10 +4,10 @@
 use Aws\Api\Shape;
 use Aws\Api\ShapeMap;
 use Aws\Api\MapShape;
-use Yoast\PHPUnitPolyfills\TestCases\TestCase;
+use PHPUnit\Framework\TestCase;
 use PHPUnit\Framework\Attributes\CoversClass;
 
-#[CoversClass(\Aws\Api\MapShape::class)]
+#[CoversClass(MapShape::class)]
 class MapShapeTest extends TestCase
 {
     public function testReturnsValue()

tests/Api/OperationTest.php

@@ -4,10 +4,10 @@
 use Aws\Api\Shape;
 use Aws\Api\ShapeMap;
 use Aws\Api\Operation;
-use Yoast\PHPUnitPolyfills\TestCases\TestCase;
+use PHPUnit\Framework\TestCase;
 use PHPUnit\Framework\Attributes\CoversClass;
 
-#[CoversClass(\Aws\Api\Operation::class)]
+#[CoversClass(Operation::class)]
 class OperationTest extends TestCase
 {
     public function testCreatesDefaultMethodAndUri()

tests/Api/Parser/ComplianceTest.php

@@ -13,15 +13,23 @@
 use PHPUnit\Framework\TestCase;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\CoversClass;
+use Aws\Api\Parser\AbstractParser;
+use Aws\Api\Parser\AbstractRestParser;
+use Aws\Api\Parser\JsonRpcParser;
+use Aws\Api\Parser\JsonParser;
+use Aws\Api\Parser\RestJsonParser;
+use Aws\Api\Parser\RestXmlParser;
+use Aws\Api\Parser\QueryParser;
+use Aws\Api\Parser\XmlParser;
 
-#[CoversClass(\Aws\Api\Parser\AbstractParser::class)]
-#[CoversClass(\Aws\Api\Parser\AbstractRestParser::class)]
-#[CoversClass(\Aws\Api\Parser\JsonRpcParser::class)]
-#[CoversClass(\Aws\Api\Parser\JsonParser::class)]
-#[CoversClass(\Aws\Api\Parser\RestJsonParser::class)]
-#[CoversClass(\Aws\Api\Parser\RestXmlParser::class)]
-#[CoversClass(\Aws\Api\Parser\QueryParser::class)]
-#[CoversClass(\Aws\Api\Parser\XmlParser::class)]
+#[CoversClass(AbstractParser::class)]
+#[CoversClass(AbstractRestParser::class)]
+#[CoversClass(JsonRpcParser::class)]
+#[CoversClass(JsonParser::class)]
+#[CoversClass(RestJsonParser::class)]
+#[CoversClass(RestXmlParser::class)]
+#[CoversClass(QueryParser::class)]
+#[CoversClass(XmlParser::class)]
 class ComplianceTest extends TestCase
 {
     use UsesServiceTrait;
@@ -104,17 +112,6 @@ public static function caseProvider(): \Generator
         }
     }
 
-    /**
-     *
-     * @param $about
-     * @param Service $service
-     * @param $name
-     * @param array $expectedResult
-     * @param $res
-     * @param string|null $errorCode
-     * @param string|null $errorMessage
-
- */
     #[DataProvider('caseProvider')]
     public function testPassesComplianceTest(
         string $about,
@@ -151,7 +148,6 @@ public function testPassesComplianceTest(
 
         $this->fixTimestamps($result, $service->getOperation($name)->getOutput());
         $this->assertEquals($expectedResult, $result);
-        $this->assertTrue(true);
     }
 
     private function fixTimestamps(mixed &$data, Shape $shape): void