feat: S3 transfer manager improvements#3247
Merged
stobrien89 merged 24 commits intoMar 30, 2026
Merged
Conversation
Until phpunit10 support is release we must use annotations for covers and dataProvider within tests.
yenfryherrerafeliz
changed the title
stobrien89
requested changes
Mar 11, 2026
- Address some formatting issues. - Fixed arguments passed to ResumableDownload - Add test coverage for: - DirectoryProgressTracker - DirectoryTransferProgressAggregator - DirectoryTransferProgressSnapshot - DirectoryDownloader - DirectoryUploader
Contributor
Author
|
stobrien89
requested changes
Mar 19, 2026
stobrien89
left a comment
stobrien89
left a comment
Member
There was a problem hiding this comment.
Just a few more questions/comments
| * | ||
| * @return bool | ||
| */ | ||
| private function writePartToDestinationHandle(array $response): bool |
Member
There was a problem hiding this comment.
Question: do part numbers start at 1 or 0? If zero, I think this might be exposed to an off-by-one error
Contributor
Author
There was a problem hiding this comment.
Part numbers start at 1 actually.
| $this->body->rewind(); | ||
| } | ||
|
|
||
| $partNo = 0; |
Member
There was a problem hiding this comment.
Does resume data store 1-based part numbers? Might be a mismatch during resume skip logic
Contributor
Author
There was a problem hiding this comment.
$partNo is incremented at line 388, which will unlikely cause a resumable
persist mismatch. Is there any other mismatch you are referring to here, that I
may be missing?
| $chunk = $body->read(self::READ_BUFFER_SIZE); | ||
|
|
||
| if (fwrite($this->handle, $chunk) === false) { | ||
| throw new FileDownloadException("Failed to write data to temporary file."); |
Member
There was a problem hiding this comment.
question: where do these exceptions bubble up to?
Contributor
Author
- Add validation for when resuming an upload and the source file changed - Add test coverage for the behavior when resuming upload and source file changed - Address some styling issues
stobrien89
requested changes
Mar 25, 2026
stobrien89
left a comment
stobrien89
left a comment
Member
There was a problem hiding this comment.
A couple more comments. Thanks for making the changes to the CBOR tests also
stobrien89
approved these changes
Mar 27, 2026
stobrien89
left a comment
stobrien89
left a comment
Member
There was a problem hiding this comment.
Overall, looks good- just a couple of formatting nits. Needs a changelog entry and a new integ/smoke test run before merging.
Contributor
Author
|
stobrien89
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.