Skip to content

fix: cast generated header values to strings#3289

Merged
stobrien89 merged 1 commit into
aws:masterfrom
GrahamCampbell:fix/psr7-string-header-values
May 27, 2026
Merged

fix: cast generated header values to strings#3289
stobrien89 merged 1 commit into
aws:masterfrom
GrahamCampbell:fix/psr7-string-header-values

Conversation

@GrahamCampbell

Copy link
Copy Markdown
Contributor

Hi there. The Guzzle maintainer here again. I am working on the next major version of Guzzle with a focus on security hardening and reducing security-foot guns. As part of those changes, the next major version will disallow non-string header values. I will be triggering deprecations soon on the current major version series, which will start to impact the AWS PHP SDK, unless it is first modified to stop passing non-string header values. And thus, that is what this PR does.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@stobrien89 stobrien89 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GrahamCampbell, looks good. Just one thing: could you add a changelog entry by creating .changes/nextrelease and adding a json file by any name with contents in the following format:

[
    {
        "type": "bugfix",
        "category": "Api",
        "description": "<description>"
    }
]

just in the off chance someone hits the new validation paths.

@GrahamCampbell GrahamCampbell force-pushed the fix/psr7-string-header-values branch from cbbfaae to 8829752 Compare May 27, 2026 10:42
@GrahamCampbell

Copy link
Copy Markdown
Contributor Author

Done.

@stobrien89 stobrien89 merged commit 7ebd05d into aws:master May 27, 2026
17 checks passed
@GrahamCampbell GrahamCampbell deleted the fix/psr7-string-header-values branch May 27, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants