fix: cast generated header values to strings#3289
Merged
stobrien89 merged 1 commit intoMay 27, 2026
Merged
Conversation
stobrien89
requested changes
May 26, 2026
stobrien89
left a comment
Member
There was a problem hiding this comment.
Thanks @GrahamCampbell, looks good. Just one thing: could you add a changelog entry by creating .changes/nextrelease and adding a json file by any name with contents in the following format:
[
{
"type": "bugfix",
"category": "Api",
"description": "<description>"
}
]
just in the off chance someone hits the new validation paths.
cbbfaae to
8829752
Compare
Contributor
Author
|
Done. |
stobrien89
approved these changes
May 27, 2026
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there. The Guzzle maintainer here again. I am working on the next major version of Guzzle with a focus on security hardening and reducing security-foot guns. As part of those changes, the next major version will disallow non-string header values. I will be triggering deprecations soon on the current major version series, which will start to impact the AWS PHP SDK, unless it is first modified to stop passing non-string header values. And thus, that is what this PR does.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.