bugfix: prevent ObjectUploader from closing user-provided resource handles#3296
Merged
stobrien89 merged 1 commit intoJun 2, 2026
Merged
Conversation
1 task
stobrien89
force-pushed
the
bugfix-objectuploader-stream-handling
branch
from
7cf73ac to
61c1a09
Compare
smilkuri
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
closes #3295
Description of changes:
ObjectUploaderwraps user-provided PHP resources in aPsr7\StreamviaUtils::streamFor().Stream::__destruct()callsfclose()on the underlying resource. Before #3290, a cyclic reference in the retry middleware kept the Stream alive indefinitely, so__destruct()never fired during the request lifecycle. After #3290 fixed the cycle, the Stream destructs promptly and closes the user's handle beforeupload()returns.This change wraps user-provided resources with
FnStream::decorate(), overridingclose()to calldetach()instead offclose(). The SDK no longer takes ownership of resources it did not open.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.