Skip to content

Remove PowerMock, Move to JUnit 5, target Java 8 again.#289

Merged
simonmarty merged 10 commits into
aws:v2from
simonmarty:v2
Sep 24, 2025
Merged

Remove PowerMock, Move to JUnit 5, target Java 8 again.#289
simonmarty merged 10 commits into
aws:v2from
simonmarty:v2

Conversation

@simonmarty

@simonmarty simonmarty commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

Issue #, if available:

Description of changes:

  • Move to JUnit 5.
  • Move to Mockito 5.
  • Remove PowerMock.
  • Moved from system-rules to system-stubs-jupiter since the first is not supported on JUnit 5.
  • Updated all dependencies
  • Updated the GitHub action workflow to build using JDK 17. (JDK 11 minimum is required for system-rules-jupiter, the library output is still Java 8 compatible.
  • Set the maven-compiler-plugin target version to Java 8 using release. Explanation here.
  • Enable auto-publish on the Maven sonatype plugin.
  • Move from mockito-inline to mockito-core and its JUnit 5 plugin. The default mockmaker is mockito-inline in Mockito 5.
  • Silence some test warnings by enabling dynamic agent loading. Mockito and systemstubs use byte-buddy to intercept calls.

This also fixes code coverage output.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

simonmarty and others added 7 commits September 23, 2025 21:44
Bumps the dependencies group with 4 updates in the / directory: software.amazon.awssdk:secretsmanager, [org.projectlombok:lombok](https://github.com/projectlombok/lombok), [com.fasterxml.jackson.core:jackson-databind](https://github.com/FasterXML/jackson) and [org.sonatype.central:central-publishing-maven-plugin](https://github.com/sonatype/central-publishing-maven-plugin).


Updates `software.amazon.awssdk:secretsmanager` from 2.34.0 to 2.34.2

Updates `org.projectlombok:lombok` from 1.18.38 to 1.18.42
- [Changelog](https://github.com/projectlombok/lombok/blob/master/doc/changelog.markdown)
- [Commits](projectlombok/lombok@v1.18.38...v1.18.42)

Updates `com.fasterxml.jackson.core:jackson-databind` from 2.19.0 to 2.20.0
- [Commits](https://github.com/FasterXML/jackson/commits)

Updates `org.sonatype.central:central-publishing-maven-plugin` from 0.8.0 to 0.9.0
- [Commits](https://github.com/sonatype/central-publishing-maven-plugin/commits)

---
updated-dependencies:
- dependency-name: software.amazon.awssdk:secretsmanager
  dependency-version: 2.34.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
- dependency-name: org.projectlombok:lombok
  dependency-version: 1.18.42
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
- dependency-name: com.fasterxml.jackson.core:jackson-databind
  dependency-version: 2.20.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dependencies
- dependency-name: org.sonatype.central:central-publishing-maven-plugin
  dependency-version: 0.9.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
…42bdf3bc06

Bump the dependencies group across 1 directory with 4 updates
@simonmarty simonmarty requested a review from a team as a code owner September 24, 2025 06:17
@codecov

codecov Bot commented Sep 24, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.24%. Comparing base (0f59cbb) to head (8682a80).

Additional details and impacted files
@@              Coverage Diff              @@
##                 v2     #289       +/-   ##
=============================================
+ Coverage     24.86%   82.24%   +57.37%     
- Complexity       41      143      +102     
=============================================
  Files            12       12               
  Lines           366      366               
  Branches         45       45               
=============================================
+ Hits             91      301      +210     
+ Misses          273       58      -215     
- Partials          2        7        +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread .github/workflows/CI.yml
@simonmarty simonmarty merged commit 7392598 into aws:v2 Sep 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants