make sizeBytes optional and add changelog

Zee2413 · Zee2413 · commit da530811fdf7 · 2026-04-07T13:27:51.000-04:00
diff --git a/packages/core/src/awsService/cloudformation/documents/documentManager.ts b/packages/core/src/awsService/cloudformation/documents/documentManager.ts
@@ -16,7 +16,7 @@ export type DocumentMetadata = {
     languageId: string
     version: number
     lineCount: number
-    sizeBytes: number
+    sizeBytes?: number
 }
 
 const DocumentsMetadataNotification = new NotificationType<DocumentMetadata[]>('aws/documents/metadata')
@@ -53,6 +53,6 @@ export class DocumentManager {
             )
             return false
         }
-        return doc.sizeBytes > DocumentManager.cfnTemplateBodyMaxBytes
+        return (doc.sizeBytes ?? 0) > DocumentManager.cfnTemplateBodyMaxBytes
     }
 }
diff --git a/packages/toolkit/.changes/next-release/Feature-a17c80f9-ddda-443b-bdc5-3cf5fa068508.json b/packages/toolkit/.changes/next-release/Feature-a17c80f9-ddda-443b-bdc5-3cf5fa068508.json
@@ -0,0 +1,4 @@
+{
+	"type": "Feature",
+	"description": "CloudFormation Language Server: templates exceeding 51KB now automatically enforce S3 upload instead of silently failing at deployment"
+}

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ export type DocumentMetadata = {`
`16`	`16`	`languageId: string`
`17`	`17`	`version: number`
`18`	`18`	`lineCount: number`
`19`		`- sizeBytes: number`
	`19`	`+ sizeBytes?: number`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`const DocumentsMetadataNotification = new NotificationType<DocumentMetadata[]>('aws/documents/metadata')`
`@@ -53,6 +53,6 @@ export class DocumentManager {`
`53`	`53`	`)`
`54`	`54`	`return false`
`55`	`55`	`}`
`56`		`- return doc.sizeBytes > DocumentManager.cfnTemplateBodyMaxBytes`
	`56`	`+ return (doc.sizeBytes ?? 0) > DocumentManager.cfnTemplateBodyMaxBytes`
`57`	`57`	`}`
`58`	`58`	`}`
-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +{
 +	"type": "Feature",
 +	"description": "CloudFormation Language Server: templates exceeding 51KB now automatically enforce S3 upload instead of silently failing at deployment"
 +}